Issue #1545 - override buffer-size parameter at layer level - revised #1566

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@lexman

No description provided.

@lexman

This pull request is a correction of former one : #1545

@springmeyer
Mapnik member

Thanks. So, I need more time to review this. I'm not convinced that the layer object is the best spot for this parameter. I'd like to give thought to it being on a style. Thanks for your patience. I'll report back once I've had time to play with the patch.

@lexman

Beware, if you link the buffer-size parameter to styles, it might not play well with cache-features.

@lexman

Hello, did you manage to think about this ? Do you still think overinding of biuffer-size should be on a style ?

@springmeyer
Mapnik member

Thanks, merged! Apologies for the epic wait, patch was excellent. I touched up the tests a bit is all (preferred not to use pycairo since I rarely have it built).

@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this pull request Aug 22, 2013
@springmeyer springmeyer Add layer buffer-size to changelog - refs #1566,#1545,#781 ecb9e59
@gravitystorm gravitystorm pushed a commit to gravitystorm/mapnik-reference that referenced this pull request Jan 24, 2014
@springmeyer springmeyer touchup layer buffer-size doc as per change made in mapnik 2.2 (mapni… c4ef3ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment