set clipping off by default for markers, shields, and text #1608

Closed
wants to merge 2 commits into from

2 participants

@springmeyer
Mapnik member

refs #1569

@springmeyer springmeyer set clipping off by default for markers, shields, and text (point/bui…
…lding do not support clipping so do not need this modification) - refs #1569
7138812
@migurski
Mapnik member

I’ve added default clip=false to Cascadenik for text and shields, but I’m finding that the output XML for TextSymbolizer and ShieldSymbolizer does not include the clip="false" attribute.

Nevermind, tracking a confusion of Mapnik installations. Looks OK after all.

@springmeyer
Mapnik member

Okay. If you do notice anything odd like that definitely post a ticket. We are planning to cut 2.1.1 soon (weeks range).

@migurski
Mapnik member

Thanks, will do!

@springmeyer springmeyer was assigned May 15, 2013
@springmeyer
Mapnik member

pushing ton 3.x milestone. Not feeling comfortable that this big of a change is warranted in 2.x. Users can just turn clipping off for the time being in their styles as they have been doing. In 3.x we can revisit this - it may be that we don't want clipping on for any symbolizers by default.

@springmeyer
Mapnik member

closing, this is going to land, but in master (future 3.x) once expr-v2 lands, since the way symbolizer defaults work have changed. Tracked in #2146

@springmeyer springmeyer closed this Feb 9, 2014
@springmeyer springmeyer deleted the clipping-off-for-placement branch Feb 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment