Fix marker-multi-policy test. Closes #1612 #1613

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@strk
Contributor

strk commented Nov 29, 2012

The test was indeed bogus (didn't set bbox correctly).
I took the chance to also simplify the data.
Closes #1612

@strk

This comment has been minimized.

Show comment Hide comment
@strk

strk Nov 29, 2012

Contributor

NOTE: the failing travis is unrelated (missing Rakefile)

Contributor

strk commented Nov 29, 2012

NOTE: the failing travis is unrelated (missing Rakefile)

@springmeyer

This comment has been minimized.

Show comment Hide comment
@springmeyer

springmeyer Nov 29, 2012

Member

I would really prefer fixes go into master and then once clearly working then backported.

Member

springmeyer commented Nov 29, 2012

I would really prefer fixes go into master and then once clearly working then backported.

@strk

This comment has been minimized.

Show comment Hide comment
@strk

strk Nov 29, 2012

Contributor

I've split up the tasks between the fix for whole multi-centroid computation and marker-multi-policy test running, so they don't mix up each other.
This one is safe to merge as it simply fixes the testcase.
#1615 is the equivalent for master.

The case used in that test is not affected by the "whole-multi-centroid" bug and I hadn't found an easy way to affect it, so gave up and added a new test for that bug instead.

Contributor

strk commented Nov 29, 2012

I've split up the tasks between the fix for whole multi-centroid computation and marker-multi-policy test running, so they don't mix up each other.
This one is safe to merge as it simply fixes the testcase.
#1615 is the equivalent for master.

The case used in that test is not affected by the "whole-multi-centroid" bug and I hadn't found an easy way to affect it, so gave up and added a new test for that bug instead.

@springmeyer

This comment has been minimized.

Show comment Hide comment
@springmeyer

springmeyer Nov 30, 2012

Member

this one won't merge automatically. working on integrating manually.

Member

springmeyer commented Nov 30, 2012

this one won't merge automatically. working on integrating manually.

@strk

This comment has been minimized.

Show comment Hide comment
@strk

strk Nov 30, 2012

Contributor

Thanks a lot Dane, 2.1.1 is going to rock ! :)

Contributor

strk commented Nov 30, 2012

Thanks a lot Dane, 2.1.1 is going to rock ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment