Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix postgresql connection leaks on error #1709

Merged
merged 1 commit into from Apr 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

strk commented Jan 31, 2013

See #1708

Owner

springmeyer commented Jan 31, 2013

Before considering backporting I think we need tests that are able to replicate the problem before the patch and clearly show it is fixed after.

Contributor

strk commented Jan 31, 2013

It takes a memory checker to test this. Do we want to start a valgrind-based suite ?

Contributor

strk commented Mar 28, 2013

The equivalent of this patch was merged in master (#1764)

@springmeyer springmeyer closed this Apr 2, 2013

@springmeyer springmeyer reopened this Apr 2, 2013

springmeyer pushed a commit that referenced this pull request Apr 2, 2013

Merge pull request #1709 from strk/2.1.x-out_of_pool_slots
Fix postgresql connection leaks on error

@springmeyer springmeyer merged commit 88f8d99 into mapnik:2.1.x Apr 2, 2013

Owner

springmeyer commented Apr 2, 2013

note: amended in c6fd387 to avoid crash in constructor if the connection is not initialized. I did not replicate this but it looks like an obvious problem that could occur given the way the patch was made.

@strk strk deleted the strk:2.1.x-out_of_pool_slots branch Apr 3, 2013

Contributor

strk commented Apr 3, 2013

Yep, thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment