Skip to content

fix: makes serveral header definitions static to support static library builds - #4006

Closed
nikhedonia wants to merge 1 commit into
mapnik:masterfrom
nikhedonia:fix/nonstatic-definition
Closed

fix: makes serveral header definitions static to support static library builds#4006
nikhedonia wants to merge 1 commit into
mapnik:masterfrom
nikhedonia:fix/nonstatic-definition

Conversation

@nikhedonia

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Oct 30, 2018

Copy link
Copy Markdown

Codecov Report

Merging #4006 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4006      +/-   ##
==========================================
+ Coverage   71.26%   71.27%   +<.01%     
==========================================
  Files         441      441              
  Lines       23073    22990      -83     
==========================================
- Hits        16443    16386      -57     
+ Misses       6630     6604      -26
Impacted Files Coverage Δ
...lude/mapnik/json/unicode_string_grammar_x3_def.hpp 100% <100%> (ø) ⬆️
.../mapnik/renderer_common/apply_vertex_converter.hpp 0% <0%> (-100%) ⬇️
include/mapnik/symbolizer_base.hpp 0% <0%> (-100%) ⬇️
include/mapnik/group/group_rule.hpp 0% <0%> (-100%) ⬇️
include/mapnik/palette.hpp 0% <0%> (-60%) ⬇️
include/mapnik/enumeration.hpp 25% <0%> (-56.82%) ⬇️
...clude/mapnik/renderer_common/pattern_alignment.hpp 0% <0%> (-55.56%) ⬇️
include/mapnik/rule.hpp 0% <0%> (-50%) ⬇️
...clude/mapnik/group/group_symbolizer_properties.hpp 50% <0%> (-50%) ⬇️
include/mapnik/feature_type_style.hpp 0% <0%> (-50%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da69fdf...b26f95c. Read the comment docs.

@artemp

artemp commented Dec 3, 2018

Copy link
Copy Markdown
Member

applied in e583063

@artemp artemp closed this Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants