Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upVector patterns with Cairo #4009
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Nov 2, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #4009 +/- ##
==========================================
- Coverage 71.69% 71.51% -0.18%
==========================================
Files 441 441
Lines 23391 23029 -362
==========================================
- Hits 16770 16470 -300
+ Misses 6621 6559 -62
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
@talaj - great feature! Is this PR ready for merging ? |
This comment has been minimized.
This comment has been minimized.
@artemp Yes. |
This comment has been minimized.
This comment has been minimized.
@talaj - could you help fixing |
This comment has been minimized.
This comment has been minimized.
@artemp - Sure, I will take a look. |
This comment has been minimized.
This comment has been minimized.
|
talaj
added some commits
Nov 2, 2018
talaj
force-pushed the
mapycz:cairo-polygon-pattern-vectorial
branch
from
40ee482
to
91b868d
Nov 21, 2018
This comment has been minimized.
This comment has been minimized.
Rebased. |
artemp
merged commit abcd96b
into
mapnik:master
Nov 21, 2018
talaj
referenced this pull request
Feb 7, 2019
Closed
Do you plan to merge changes back to upstream? #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
talaj commentedNov 2, 2018
•
edited
Cairo backend is rasterizing SVG patterns prior to rendering. This leads to poor result when rendering to PDF or SVG. This pull request adds ability to render SVG patterns as vectors.
The implementation is using Cairo recording surface. An SVG is rendered to the recording surface and this surface is then used as a pattern.