New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector patterns with Cairo #4009

Merged
merged 2 commits into from Nov 21, 2018

Conversation

Projects
None yet
2 participants
@talaj
Copy link
Member

talaj commented Nov 2, 2018

Cairo backend is rasterizing SVG patterns prior to rendering. This leads to poor result when rendering to PDF or SVG. This pull request adds ability to render SVG patterns as vectors.

The implementation is using Cairo recording surface. An SVG is rendered to the recording surface and this surface is then used as a pattern.

@talaj talaj referenced this pull request Nov 2, 2018

Merged

Vector patterns with Cairo #78

@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 2, 2018

Codecov Report

Merging #4009 into master will decrease coverage by 0.17%.
The diff coverage is 20.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4009      +/-   ##
==========================================
- Coverage   71.69%   71.51%   -0.18%     
==========================================
  Files         441      441              
  Lines       23391    23029     -362     
==========================================
- Hits        16770    16470     -300     
+ Misses       6621     6559      -62
Impacted Files Coverage Δ
include/mapnik/cairo/cairo_context.hpp 100% <100%> (+100%) ⬆️
include/mapnik/cairo/render_polygon_pattern.hpp 42.85% <15.21%> (-28.58%) ⬇️
include/mapnik/symbolizer_base.hpp 0% <0%> (-100%) ⬇️
include/mapnik/marker_cache.hpp 0% <0%> (-100%) ⬇️
include/mapnik/boolean.hpp 0% <0%> (-100%) ⬇️
include/mapnik/featureset.hpp 0% <0%> (-100%) ⬇️
include/mapnik/raster_colorizer.hpp 0% <0%> (-85.72%) ⬇️
include/mapnik/util/singleton.hpp 0% <0%> (-85%) ⬇️
plugins/input/csv/csv_utils.hpp 18.18% <0%> (-77.28%) ⬇️
include/mapnik/params.hpp 0% <0%> (-66.67%) ⬇️
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 940f0dc...91b868d. Read the comment docs.

@artemp

This comment has been minimized.

Copy link
Member

artemp commented Nov 21, 2018

@talaj - great feature! Is this PR ready for merging ?

@talaj

This comment has been minimized.

Copy link
Member Author

talaj commented Nov 21, 2018

@artemp Yes.

@artemp

This comment has been minimized.

Copy link
Member

artemp commented Nov 21, 2018

@talaj - could you help fixing data-visual . I'm locally getting pattern alignment failures. I wonder if data-visual needs rebasing ?

@talaj

This comment has been minimized.

Copy link
Member Author

talaj commented Nov 21, 2018

@artemp - Sure, I will take a look.

@artemp

This comment has been minimized.

Copy link
Member

artemp commented Nov 21, 2018

👍

@talaj talaj force-pushed the mapycz:cairo-polygon-pattern-vectorial branch from 40ee482 to 91b868d Nov 21, 2018

@talaj

This comment has been minimized.

Copy link
Member Author

talaj commented Nov 21, 2018

Rebased.

@artemp artemp merged commit abcd96b into mapnik:master Nov 21, 2018

1 of 3 checks passed

codecov/patch 20.4% of diff hit (target 71.69%)
Details
codecov/project 71.51% (-0.18%) compared to 940f0dc
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment