Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

remove bind arg completely

  • Loading branch information...
commit 0cea6c729188196c936914dcc1c1e75921345465 1 parent 55061ed
Dane Springmeyer springmeyer authored
Showing with 2 additions and 15 deletions.
  1. +0 −13 src/mapnik_memory_datasource.cpp
  2. +2 −2 src/mem_datasource.hpp
13 src/mapnik_memory_datasource.cpp
View
@@ -74,19 +74,6 @@ Handle<Value> MemoryDatasource::New(const Arguments& args)
Local<Object> options = args[0]->ToObject();
- // TODO - maybe validate in js?
-
- bool bind=true;
- if (options->Has(String::New("bind")))
- {
- Local<Value> bind_opt = options->Get(String::New("bind"));
- if (!bind_opt->IsBoolean())
- return ThrowException(Exception::TypeError(
- String::New("'bind' must be a Boolean")));
-
- bind = bind_opt->BooleanValue();
- }
-
mapnik::parameters params;
Local<Array> names = options->GetPropertyNames();
uint32_t i = 0;
4 src/mem_datasource.hpp
View
@@ -29,7 +29,7 @@ class js_datasource : public mapnik::datasource
{
friend class js_featureset;
public:
- js_datasource(const mapnik::parameters &params, bool bind, Local<Value> cb);
+ js_datasource(const mapnik::parameters &params, Local<Value> cb);
virtual ~js_datasource();
mapnik::datasource::datasource_t type() const;
mapnik::featureset_ptr features(const mapnik::query& q) const;
@@ -45,7 +45,7 @@ class js_datasource : public mapnik::datasource
};
-js_datasource::js_datasource(const mapnik::parameters &params, bool bind, Local<Value> cb)
+js_datasource::js_datasource(const mapnik::parameters &params, Local<Value> cb)
: datasource (params),
desc_(*params.get<std::string>("type"), *params.get<std::string>("encoding","utf-8"))
{
Please sign in to comment.
Something went wrong with that request. Please try again.