Better event and feature handling #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Map Object now contains a reference to the current projection of the map, and the displayed projection. Both are EPSG identifiers stored as strings.
Add the layer to OpenLayers after everything within MapQuery was set properly.
It was a mistake to automatically jQuery events based on the OpenLayers events. They contained data from OpenLayers which wasn't nicely wrapped into MapQuery. Now the "addlayer" event contains the MapQuery layer, not the OpenLayers one. The same is true for the "removelayer" event.
There was the one() function, to bind an event only once. It wasn't used and it's always good to prevent the API from being bloated. It even had no documentation.
Currentlt all events that OpenLayers triggers from OpenLayers.Map and OpenLayers.Layer are either wrapped or removed with a good reason. See the inline comments for more information. The events from OpenLayers.Layer.Vector aren't wrapped yet. All events that are triggered on a layer, also trigger those events on the map, but with the layer that triggered it included.
MapQuery now supports features. This means that you can retreive, add, remove or select them. The corresponding events are fired, which are: (pre)addfeature, (pre)remove, (un)selectfeature This is a huge commits that also updates the tests and widgets.
|
Volker, some really nice changes in here. Cheers +1 |
|
I haven't heard anything bad, but only good things about this pull request. Hence I dare to merge it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests leads to better event handling and also support for features