Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call OpenLayers throught HTTPS #192

Merged
merged 1 commit into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@gsueur
Copy link
Contributor

commented Jan 23, 2019

Will avoid mixed content errors when your service is deployed with HTTPS (which it should be). And won't be no harm if still HTTP.

call OpenLayers throught HTTPS
Will avoid mixed content errors when your service is deployed with HTTPS (which it should be). And won't be no harm if still HTTP.

@jmckenna jmckenna merged commit 9ec2824 into mapserver:master Jan 23, 2019

0 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@jmckenna

This comment has been minimized.

Copy link
Member

commented Jan 23, 2019

important change. thanks @gsueur !!!

@jmckenna

This comment has been minimized.

Copy link
Member

commented Feb 16, 2019

@gsueur I'm testing this in the demo, and, unfortunately my browser tries these steps:

I wonder if it is because the correct url is: https://openlayers.org/api/OpenLayers.js

I think that could be it.

Thoughts?

@gsueur

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2019

You are probably right Jeff. Sorry for the mistake.

@jmckenna

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Fixed with 0e74456

Demo works now on both HTTPS and HTTP hosts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.