Skip to content

Commit

Permalink
Resolving #4638.
Browse files Browse the repository at this point in the history
  • Loading branch information
@Schpidi
Schpidi committed May 7, 2013
1 parent 929ed6f commit 937dcb6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mapwms.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2446,7 +2446,7 @@ int msDumpLayer(mapObj *map, layerObj *lp, int nVersion, const char *script_url_
break;
}
}
if (l < lp2->numclasses)
if (lp2 && l < lp2->numclasses)
break;
}
if (j < numNestedGroups[lp->index])
Expand Down

2 comments on commit 937dcb6

@tomkralidis
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Schpidi as discussed in IRC, this has issues when I name a CLASSGROUP default.

What is the default style used here when a client then requests STYLES= or STYLES=default ?

@Schpidi
Copy link
Member Author

@Schpidi Schpidi commented on 937dcb6 May 8, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to use the name "default" add something like:

"wms_style_name" "not_default"

to WEB METDATA.

The default style, i.e. the one used with STYLES=, should be the last listed in the MapFile.

Please sign in to comment.