[Backport branch-7-6] Fix most of remaining Coverity scan warnings with high priority (#6307)

Author: MapServer-backport-bot

mapcontext.c

@@ -811,7 +811,6 @@ int msLoadMapContextGeneral(mapObj *map, CPLXMLNode *psGeneral,
 int msLoadMapContextLayer(mapObj *map, CPLXMLNode *psLayer, int nVersion,
                           char *filename, int unique_layer_names)
 {
-  char *pszProj=NULL;
   char *pszValue;
   const char *pszHash;
   char *pszName=NULL;
@@ -970,7 +969,7 @@ int msLoadMapContextLayer(mapObj *map, CPLXMLNode *psLayer, int nVersion,
   pszHash = msLookupHashTable(&(layer->metadata), "wms_srs");
   if(((pszHash == NULL) || (strcasecmp(pszHash, "") == 0)) &&
       map->projection.numargs != 0) {
-    pszProj = map->projection.args[map->projection.numargs-1];
+    char* pszProj = map->projection.args[map->projection.numargs-1];
 
     if(pszProj != NULL) {
       if(strncasecmp(pszProj, "AUTO:", 5) == 0) {
@@ -987,6 +986,7 @@ int msLoadMapContextLayer(mapObj *map, CPLXMLNode *psLayer, int nVersion,
                   pszProj);
         }
       }
+      msFree(pszProj);
     }
   }
 

mapcpl.c

@@ -195,6 +195,8 @@ void *msGetSymbol( const char * pszLibrary, const char * pszSymbolName )
     return NULL;
   }
 
+  /* We accept leakage of pLibrary */
+  /* coverity[leaked_storage] */
   return( pSymbol );
 }
 

mapfile.c

@@ -1933,12 +1933,8 @@ char* msWriteLabelToString(labelObj *label)
 
 void msInitExpression(expressionObj *exp)
 {
+  memset(exp, 0, sizeof(*exp));
   exp->type = MS_STRING;
-  exp->string = NULL;
-  exp->native_string = NULL;
-  exp->compiled = MS_FALSE;
-  exp->flags = 0;
-  exp->tokens = exp->curtoken = NULL;
 }
 
 void msFreeExpressionTokens(expressionObj *exp)

mapogcsld.c

@@ -4716,8 +4716,8 @@ char *msSLDGetAttributeNameOrValue(char *pszExpression,
           } else
             pszAttributeName[iValue++] = pszExpression[i];
         }
-        pszAttributeName[iValue] = '\0';
       }
+      pszAttributeName[iValue] = '\0';
     }
     msFreeCharArray(aszValues, nTokens);
   } else if (bOneCharCompare == 0) {
@@ -4744,8 +4744,8 @@ char *msSLDGetAttributeNameOrValue(char *pszExpression,
         } else
           pszAttributeName[iValue++] = pszExpression[i];
       }
-      pszAttributeName[iValue] = '\0';
     }
+    pszAttributeName[iValue] = '\0';
   }
 
   /* -------------------------------------------------------------------- */

mapogcsos.c

@@ -2931,16 +2931,22 @@ int msSOSParseRequest(mapObj *map, cgiRequestObj *request, sosParamsObj *sospara
     if (psXPathTmp)
       sosparams->pszRequest = msStrdup("GetCapabilities");
 
+    xmlXPathFreeObject(psXPathTmp);
+
     psXPathTmp = msLibXml2GetXPath(doc, context, (xmlChar *)"/sos:DescribeSensor");
 
     if (psXPathTmp)
       sosparams->pszRequest = msStrdup("DescribeSensor");
 
+    xmlXPathFreeObject(psXPathTmp);
+
     psXPathTmp = msLibXml2GetXPath(doc, context, (xmlChar *)"/sos:GetObservation");
 
     if (psXPathTmp)
       sosparams->pszRequest = msStrdup("GetObservation");
 
+    xmlXPathFreeObject(psXPathTmp);
+
     psXPathTmp = msLibXml2GetXPath(doc, context, (xmlChar *)"/sos:DescribeObservationType");
 
     if (psXPathTmp)

mapogr.cpp

@@ -3080,7 +3080,10 @@ int msOGRFileReadTile( layerObj *layer, msOGRFileInfo *psInfo,
 
 #ifndef IGNORE_MISSING_DATA
   if( psTileInfo == NULL && targetTile == -1 )
+  {
+    msFree(pszSRS);
     goto NextFile;
+  }
 #endif
 
   if( psTileInfo == NULL )

mapstring.c

@@ -2184,7 +2184,7 @@ int msLayerEncodeShapeAttributes( layerObj *layer, shapeObj *shape) {
   iconv_t cd = NULL;
   const char *inp;
   char *outp, *out = NULL;
-  size_t len, bufsize, bufleft, iconv_status;
+  size_t len, bufsize, bufleft;
   int i;
 
   if( !layer->encoding || !*layer->encoding || !strcasecmp(layer->encoding, "UTF-8"))
@@ -2198,6 +2198,7 @@ int msLayerEncodeShapeAttributes( layerObj *layer, shapeObj *shape) {
   }
 
   for(i=0;i <shape->numvalues; i++) {
+    int failedIconv = FALSE;
     if(!shape->values[i] || (len = strlen(shape->values[i]))==0) {
       continue;    /* Nothing to do */
     }
@@ -2210,15 +2211,18 @@ int msLayerEncodeShapeAttributes( layerObj *layer, shapeObj *shape) {
     outp = out;
 
     bufleft = bufsize;
-    iconv_status = -1;
 
     while (len > 0) {
-      iconv_status = iconv(cd, (char**)&inp, &len, &outp, &bufleft);
-      if(iconv_status == -1) {
-        msFree(out);
-        continue; /* silently ignore failed conversions */
+      const size_t iconv_status = iconv(cd, (char**)&inp, &len, &outp, &bufleft);
+      if(iconv_status == (size_t)(-1)) {
+        failedIconv = TRUE;
+        break;
       }
     }
+    if( failedIconv ) {
+      msFree(out);
+      continue; /* silently ignore failed conversions */
+    }
     out[bufsize - bufleft] = '\0';
     msFree(shape->values[i]);
     shape->values[i] = out;

mapwfs.c

@@ -5179,10 +5179,12 @@ int msWFSParseRequest(mapObj *map, cgiRequestObj *request, owsRequestObj *ows_re
           }
           /* these are unsupported requests. Just set the  */
           /* request value and return; */
-          else if (msWFSGetIndexUnsupportedOperation(psOperation->pszValue) >= 0) {
+          else {
             int idx = msWFSGetIndexUnsupportedOperation(psOperation->pszValue);
-            wfsparams->pszRequest = msStrdup(wfsUnsupportedOperations[idx]);
-            break;
+            if( idx >= 0 ) {
+              wfsparams->pszRequest = msStrdup(wfsUnsupportedOperations[idx]);
+              break;
+            }
           }
         }
       }