New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy and auth support for CONNECTIONTYPE WFS #3982

Closed
mapserver-bot opened this Issue Apr 4, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@mapserver-bot

mapserver-bot commented Apr 4, 2012

Reporter: dmorissette
Date: 2011/08/10 - 05:42
Trac URL: http://trac.osgeo.org/mapserver/ticket/3982
WFS client layers are missing support for proxy and auth support.

Ticket #571 introduced support for proxy for WMS client layers inmsPrepareWMSLayerRequest(), but the same has not been done for WFS client layers in msPrepareWFSLayerRequest().

BTW, instead of just copying and pasting the proxy and auth code from mapwmslayer.c to mapwfslayer.c, we should really move it to a shared function.

@mapserver-bot

This comment has been minimized.

Show comment
Hide comment
@mapserver-bot

mapserver-bot Apr 4, 2012

Author: dmorissette
Date: 2011/08/10 - 05:45
I attached an untested patch which is really just a port of the WMS proxy and auth handling code to mapwfslayer.c.

As I wrote above, the final fix for this should move this code to a generic function that will be called by both the WMS and WFS code.

mapserver-bot commented Apr 4, 2012

Author: dmorissette
Date: 2011/08/10 - 05:45
I attached an untested patch which is really just a port of the WMS proxy and auth handling code to mapwfslayer.c.

As I wrote above, the final fix for this should move this code to a generic function that will be called by both the WMS and WFS code.

@mapserver-bot

This comment has been minimized.

Show comment
Hide comment
@mapserver-bot

mapserver-bot Apr 5, 2012

attachment http://trac.osgeo.org/mapserver/attachment/ticket/3982/ticket3982-lazy.patch :

   Untested patch - just a lazy copy of the WMS code

mapserver-bot commented Apr 5, 2012

attachment http://trac.osgeo.org/mapserver/attachment/ticket/3982/ticket3982-lazy.patch :

   Untested patch - just a lazy copy of the WMS code

@ghost ghost assigned dmorissette Apr 5, 2012

landryb added a commit to landryb/mapserver that referenced this issue Jul 15, 2013

Add proxy and auth support to wfs client (#3982)
Copied & adapted from similar code in mapwmslayer.c.

Fix two copy-pasto errors while here, wfs_http_cookie was not
looked up.

mkofahl added a commit that referenced this issue Jul 24, 2013

Merge pull request #4708 from landryb/master
Add proxy and auth support to wfs client (#3982)

@mkofahl mkofahl closed this Jul 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment