Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding multi-label support to classes (RFC 77). #4127

Closed
mapserver-bot opened this issue Apr 4, 2012 · 14 comments
Closed

Adding multi-label support to classes (RFC 77). #4127

mapserver-bot opened this issue Apr 4, 2012 · 14 comments
Assignees
Milestone

Comments

@mapserver-bot
Copy link

Reporter: sdlime
Date: 2011/12/15 - 15:03
Trac URL: http://trac.osgeo.org/mapserver/ticket/4127
Ticket to track the implementation of RFC 77- adding multiple label support to class objects. -Steve

@mapserver-bot
Copy link
Author

Author: sdlime
Date: 2012/02/12 - 21:42
Initial implementation merged from the sandbox into trunk in ffd3a8c (r13138). -Steve

@mapserver-bot
Copy link
Author

Author: jmckenna
Date: 2012/02/13 - 19:44
Steve,

I'm trying to compile trunk (a9dfd7d (r13142)) with Windows (VC2008) and I get the following error:

mapkmlrenderer.cpp
mapkmlrenderer.cpp(44) : warning C4100: 'color' : unreferenced formal parameter
mapkmlrenderer.cpp(44) : warning C4100: 'format' : unreferenced formal parameter
mapkmlrenderer.cpp(236) : error C2039: 'label' : is not a member of 'class_obj'
        d:\build\mapserver-buildkit-2008\mapserver-trunk\mapserver.h(995) : see declaratio
n of 'class_obj'
mapkmlrenderer.cpp(236) : error C2228: left of '.position' must have class/struct/union
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio 9.0\VC\BIN\cl.EXE"'
: return code '0x2'
Stop.

Could that be related to your recent changes? (if I try with 136c85b (r13137) I don't have a problem)

@mapserver-bot
Copy link
Author

Author: sdlime
Date: 2012/02/13 - 19:59
Definitely related, I'll fix asap. If you compile without KML you should be able to work around it.

Steve

@mapserver-bot
Copy link
Author

Author: tamas
Date: 2012/02/13 - 21:25
The related mapscript functions are missing from trunk.
I also miss the reference counting approach just like for the styles has already been added within the scope of RFC24.

@mapserver-bot
Copy link
Author

Author: sdlime
Date: 2012/02/14 - 05:55
Replying to [comment:4 sdlime]:

Definitely related, I'll fix asap. If you compile without KML you should be able to work around it.

Steve

Fixed in cb06d46 (r13146). -Steve

@mapserver-bot
Copy link
Author

Author: sdlime
Date: 2012/02/14 - 05:56
Replying to [comment:5 tamas]:

The related mapscript functions are missing from trunk.
I also miss the reference counting approach just like for the styles has already been added within the scope of RFC24.

Will do. The MapScript stuff was an oversight- will mimic styleObj support on all counts.

Steve

@mapserver-bot
Copy link
Author

Author: jmckenna
Date: 2012/02/14 - 14:49
thanks Steve, the mapkmlrenderer error is gone.

@mapserver-bot
Copy link
Author

Author: rouault
Date: 2012/03/03 - 12:46
ad2933c (r13198) /trunk/mapserver/mapogroutput.c: Fix mapogroutput.c after changes related to RFC 77 (#4127)

@ghost ghost assigned sdlime Apr 5, 2012
@szekerest
Copy link
Member

Any update on the mapscript support?

@sdlime
Copy link
Member

sdlime commented May 8, 2012

Hasn't been done yet (incompetence with git is to blame). Will try tonite.

Sent from my iPad

On May 7, 2012, at 3:01 PM, Tamas Szekeresreply@reply.github.com wrote:

Any update on the mapscript support?


Reply to this email directly or view it on GitHub:
#4127 (comment)

@sdlime
Copy link
Member

sdlime commented May 8, 2012

I'm going to close this ticket. See ticket #4310 specifically for MapScript and multi-label support.

Steve

@sdlime sdlime closed this as completed May 8, 2012
tbonfort added a commit to MapServer/msautotest_DEPRECATED that referenced this issue Sep 24, 2012
@havatv
Copy link

havatv commented Oct 31, 2012

@tbonfort , @sdlime This does not seem to have been documented. Is there a separate documentation ticket?

havatv pushed a commit to MapServer/MapServer-documentation that referenced this issue Oct 31, 2012
havatv pushed a commit to MapServer/MapServer-documentation that referenced this issue Oct 31, 2012
…tation for multiple label support (style and label) (rfc 77, MapServer/MapServer#4127
@havatv
Copy link

havatv commented Oct 31, 2012

I have now added EXPRESSION and TEXT to LABEL in master. Have also updated LABEL in STYLE. @sdlime, please check - I am not familiar with this new feature.

@sdlime
Copy link
Member

sdlime commented Nov 1, 2012

EXPRESSION/TEXT in labels behave just like their counterparts in classes so referring to full documentation in those objects is perfect. Thanks! --Steve

mkofahl pushed a commit to faegi/mapserver that referenced this issue Apr 9, 2013
sdlime added a commit that referenced this issue Feb 17, 2014
…al implementation code...

git-svn-id: http://svn.osgeo.org/mapserver/trunk@13138 7532c77e-422f-0410-93f4-f0b67bdd69e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants