New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swig MapScript for Multi-Label Support #4310

Closed
sdlime opened this Issue May 8, 2012 · 16 comments

Comments

@sdlime
Member

sdlime commented May 8, 2012

Need to add methods for manipulating multiple label objects in the context of classObj's. Need to implement the RFC 24 reference counting as well (necessary attributes have been added to appropriate structures). styleObj support should serve as a pattern.

Steve

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime May 11, 2012

Member

I added three new methods for a classObj in SWIG MapScript: getLabel, addLabel, removeLabel. They mirror the style support except that order is not important for labels so addLabel doesn't take an index and just adds the new label to the end. These are in the master.

Tamas, in class.i there were some C-Sharp specific directives around insertStyle that I wasn't sure if they applied here or not. Can you comment?

Steve

Member

sdlime commented May 11, 2012

I added three new methods for a classObj in SWIG MapScript: getLabel, addLabel, removeLabel. They mirror the style support except that order is not important for labels so addLabel doesn't take an index and just adds the new label to the end. These are in the master.

Tamas, in class.i there were some C-Sharp specific directives around insertStyle that I wasn't sure if they applied here or not. Can you comment?

Steve

@szekerest

This comment has been minimized.

Show comment
Hide comment
@szekerest

szekerest May 21, 2012

Member

This change is required to update the object relationship for the c# garbage collector. Modified the code accordingly.

Member

szekerest commented May 21, 2012

This change is required to update the object relationship for the c# garbage collector. Modified the code accordingly.

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort May 23, 2012

Member

@aboudreault , have the corresponding functions been added to php mapscript ?

Member

tbonfort commented May 23, 2012

@aboudreault , have the corresponding functions been added to php mapscript ?

@aboudreault

This comment has been minimized.

Show comment
Hide comment
@aboudreault

aboudreault May 23, 2012

Member

not yet. another thing to add to my todo list.

Member

aboudreault commented May 23, 2012

not yet. another thing to add to my todo list.

@aboudreault

This comment has been minimized.

Show comment
Hide comment
@aboudreault

aboudreault May 24, 2012

Member

In my commit:

  • Fix memory leak in msAddLabelToClass()
  • Add addLabel/removeLabel/getLabel in classObj of PHP MapScript
  • Add numlabels property in classObj in PHP Mapsciprt
  • Add labelObj capability to be instantiated. (was always embedded before) (PHP and SWIG)

I think we can close this ticket?

Member

aboudreault commented May 24, 2012

In my commit:

  • Fix memory leak in msAddLabelToClass()
  • Add addLabel/removeLabel/getLabel in classObj of PHP MapScript
  • Add numlabels property in classObj in PHP Mapsciprt
  • Add labelObj capability to be instantiated. (was always embedded before) (PHP and SWIG)

I think we can close this ticket?

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime May 24, 2012

Member

I can try to add to PHP. It was my contract responsibility...

On Wed, May 23, 2012 at 10:11 AM, Thomas Bonfort
reply@reply.github.com
wrote:

@aboudreault , have the corresponding functions been added to php mapscript ?


Reply to this email directly or view it on GitHub:
#4310 (comment)

Member

sdlime commented May 24, 2012

I can try to add to PHP. It was my contract responsibility...

On Wed, May 23, 2012 at 10:11 AM, Thomas Bonfort
reply@reply.github.com
wrote:

@aboudreault , have the corresponding functions been added to php mapscript ?


Reply to this email directly or view it on GitHub:
#4310 (comment)

@aboudreault

This comment has been minimized.

Show comment
Hide comment
@aboudreault

aboudreault May 25, 2012

Member

it's done steve. Documentation is missing though...

Member

aboudreault commented May 25, 2012

it's done steve. Documentation is missing though...

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime May 26, 2012

Member

Thanks man. Let's leave open untils docs get the update. Steve

Member

sdlime commented May 26, 2012

Thanks man. Let's leave open untils docs get the update. Steve

@havatv

This comment has been minimized.

Show comment
Hide comment
@havatv

havatv Jul 25, 2012

I have updated mapscript documentation (mapscript/mapscript.txt and mapscript/php/index.txt) - mapserver/docs@ae0a68a.

Properties for class: numlabels added, label marked as removed.

Methods for class: addLabel, getLabel, removeLabel.

I have also updated two figures to indicate that multiple labels can be used for class.

If the update is OK, I hope that @aboudreault or @sdlime can close this bug. I can't.

havatv commented Jul 25, 2012

I have updated mapscript documentation (mapscript/mapscript.txt and mapscript/php/index.txt) - mapserver/docs@ae0a68a.

Properties for class: numlabels added, label marked as removed.

Methods for class: addLabel, getLabel, removeLabel.

I have also updated two figures to indicate that multiple labels can be used for class.

If the update is OK, I hope that @aboudreault or @sdlime can close this bug. I can't.

@aboudreault

This comment has been minimized.

Show comment
Hide comment
@aboudreault

aboudreault Jul 25, 2012

Member

Thanks havatv!

Member

aboudreault commented Jul 25, 2012

Thanks havatv!

@szekerest

This comment has been minimized.

Show comment
Hide comment
@szekerest

szekerest Sep 9, 2012

Member

labelObj.expression a labelObj.text is not exposed to mapscript. Also missing from the mapfile/mapscript documentation

Member

szekerest commented Sep 9, 2012

labelObj.expression a labelObj.text is not exposed to mapscript. Also missing from the mapfile/mapscript documentation

@havatv

This comment has been minimized.

Show comment
Hide comment
@havatv

havatv Apr 3, 2013

@tbonfort, should something be done also for PHP mapscript? I could not find settext and setexpression in the 6.2 PHP code.

havatv commented Apr 3, 2013

@tbonfort, should something be done also for PHP mapscript? I could not find settext and setexpression in the 6.2 PHP code.

mkofahl pushed a commit to faegi/mapserver that referenced this issue Apr 9, 2013

@jmckenna

This comment has been minimized.

Show comment
Hide comment
@jmckenna

jmckenna Apr 15, 2013

Member

Reopening. LabelObj text and expression params are not exposed yet in PHP MapScript.

Member

jmckenna commented Apr 15, 2013

Reopening. LabelObj text and expression params are not exposed yet in PHP MapScript.

@jmckenna jmckenna reopened this Apr 15, 2013

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 15, 2013

Member

not sure if this can be ready for 6.2.1 . @aboudreault ?

Member

tbonfort commented Apr 15, 2013

not sure if this can be ready for 6.2.1 . @aboudreault ?

@aboudreault

This comment has been minimized.

Show comment
Hide comment
@aboudreault

aboudreault Apr 15, 2013

Member

will do tomorrow morning

Member

aboudreault commented Apr 15, 2013

will do tomorrow morning

@aboudreault

This comment has been minimized.

Show comment
Hide comment
@aboudreault

aboudreault Apr 16, 2013

Member

Fixed in branch-6-2 and master.

Member

aboudreault commented Apr 16, 2013

Fixed in branch-6-2 and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment