Swig MapScript for Multi-Label Support #4310

Closed
sdlime opened this Issue May 8, 2012 · 16 comments

Projects

None yet

6 participants

@sdlime
Member
sdlime commented May 8, 2012

Need to add methods for manipulating multiple label objects in the context of classObj's. Need to implement the RFC 24 reference counting as well (necessary attributes have been added to appropriate structures). styleObj support should serve as a pattern.

Steve

@sdlime sdlime was assigned May 8, 2012
@sdlime
Member
sdlime commented May 11, 2012

I added three new methods for a classObj in SWIG MapScript: getLabel, addLabel, removeLabel. They mirror the style support except that order is not important for labels so addLabel doesn't take an index and just adds the new label to the end. These are in the master.

Tamas, in class.i there were some C-Sharp specific directives around insertStyle that I wasn't sure if they applied here or not. Can you comment?

Steve

@szekerest
Member

This change is required to update the object relationship for the c# garbage collector. Modified the code accordingly.

@tbonfort
Member

@aboudreault , have the corresponding functions been added to php mapscript ?

@aboudreault
Member

not yet. another thing to add to my todo list.

@aboudreault aboudreault was assigned May 23, 2012
@aboudreault aboudreault pushed a commit that referenced this issue May 24, 2012
Alan Boudreault Swig/PHP mapscript for multi-label support (#4310) af74530
@aboudreault
Member

In my commit:

  • Fix memory leak in msAddLabelToClass()
  • Add addLabel/removeLabel/getLabel in classObj of PHP MapScript
  • Add numlabels property in classObj in PHP Mapsciprt
  • Add labelObj capability to be instantiated. (was always embedded before) (PHP and SWIG)

I think we can close this ticket?

@sdlime
Member
sdlime commented May 24, 2012

I can try to add to PHP. It was my contract responsibility...

On Wed, May 23, 2012 at 10:11 AM, Thomas Bonfort
reply@reply.github.com
wrote:

@aboudreault , have the corresponding functions been added to php mapscript ?


Reply to this email directly or view it on GitHub:
#4310 (comment)

@aboudreault
Member

it's done steve. Documentation is missing though...

@sdlime
Member
sdlime commented May 26, 2012

Thanks man. Let's leave open untils docs get the update. Steve

@havatv havatv pushed a commit to mapserver/docs that referenced this issue Jul 25, 2012
Håvard Tveite Added mapscript documentation for multiple class label support (swig … ae0a68a
@havatv
Contributor
havatv commented Jul 25, 2012

I have updated mapscript documentation (mapscript/mapscript.txt and mapscript/php/index.txt) - mapserver/docs@ae0a68a.

Properties for class: numlabels added, label marked as removed.

Methods for class: addLabel, getLabel, removeLabel.

I have also updated two figures to indicate that multiple labels can be used for class.

If the update is OK, I hope that @aboudreault or @sdlime can close this bug. I can't.

@aboudreault
Member

Thanks havatv!

@szekerest
Member

labelObj.expression a labelObj.text is not exposed to mapscript. Also missing from the mapfile/mapscript documentation

@szekerest szekerest reopened this Sep 9, 2012
@tbonfort tbonfort closed this Mar 29, 2013
@havatv
Contributor
havatv commented Apr 3, 2013

@tbonfort, should something be done also for PHP mapscript? I could not find settext and setexpression in the 6.2 PHP code.

@mkofahl mkofahl pushed a commit to faegi/mapserver that referenced this issue Apr 9, 2013
@szekerest szekerest Expose labelObj.text and labelObj.expression (#4310) af528d3
@jmckenna
Member

Reopening. LabelObj text and expression params are not exposed yet in PHP MapScript.

@jmckenna jmckenna reopened this Apr 15, 2013
@tbonfort
Member

not sure if this can be ready for 6.2.1 . @aboudreault ?

@aboudreault
Member

will do tomorrow morning

@aboudreault
Member

Fixed in branch-6-2 and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment