Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip layers with specified WMS errors #4411

Closed
PhilAnzel opened this issue Aug 1, 2012 · 7 comments
Closed

Skip layers with specified WMS errors #4411

PhilAnzel opened this issue Aug 1, 2012 · 7 comments
Assignees

Comments

@PhilAnzel
Copy link

WMS client layers may fail with HTTP errors such as "404", "408" or "504" due to transient network or server problems. In case of such a failure, no layers are drawn and an exception is thrown. It would be better to be able to specify on a per-layer basis those layers that can simply be skipped if an error occurs. This might be by means of a CONFIGURE statement that specifies the error to ignore, such as

  CONFIG ON_WMS_ERROR "IGNORE=404"
  CONFIG ON_WMS_ERROR "IGNORE=408,504"

(thanks to Steve W for this suggested usage).

@dmorissette
Copy link
Contributor

To remain consistent with the other config info used for CONNECTIONTYPE WMS and WFS layers which are provided through "ows_...", "wms_...", "wfs_..." metadata entries, we should probably use metadata for this as well instead of CONFIG options.

We'd also need to think about which actions other than IGNORE we need to support. In http://mapserver.org/development/rfc/ms-rfc-47.html for IGNORE_MISSING_DATA the actions were IGNORE, LOG or FAIL, with FAIL being the default.

Finally, we need to take into consideration that we cannot have multiple metadata entries with the same key.

Perhaps something as follows would do?

METADATA
  "ows_onerror"     "LOG"    # Set new default behavior to log and skip all errors unless explicitly specified otherwise
  "ows_onerror_404" "FAIL"   # FAIL on 404 errors
  "ows_onerror_408" "IGNORE" # Silently ignore request timeout errors
  "ows_onerror_504" "IGNORE" # Silently ignore proxy timeout errors
END

@PhilAnzel
Copy link
Author

Thank you, Daniel, that would certainly make for a more robust server. - Phil

@ghost ghost assigned aboudreault Aug 1, 2012
@dmorissette
Copy link
Contributor

Unfortunately this will have to wait for 6.4. I'll assign this ticket to @aboudreault. Please ping us again after the 6.2 release is out to make sure we don't forget.

@tbonfort
Copy link
Member

tbonfort commented Aug 8, 2013

too late for 6.4, demilestoning

@PhilAnzel
Copy link
Author

Ping: a reminder, this would still be handy to have.

@PhilAnzel PhilAnzel reopened this Jun 12, 2014
@dmorissette
Copy link
Contributor

Agreed this would be nice to have. Unfortunately I don't see myself having time anytime soon, so hopefully another dev can take it.

@mapserver-bot
Copy link

This is an automated comment

This issue has been closed due to lack of activity. This doesn't mean the issue is invalid, it simply got no attention within the last year. Please reopen with missing/relevant information if still valid.

Typically, issues fall in this state for one of the following reasons:

  • Hard, impossible or not enough information to reproduce
  • Missing test case
  • Lack of a champion with interest and/or funding to address the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants