New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC103: Layer Level Encoding tracking issue #4758

Closed
tbonfort opened this Issue Sep 24, 2013 · 8 comments

Comments

Projects
None yet
3 participants
@tbonfort
Member

tbonfort commented Sep 24, 2013

This is to track updates related to RFC103: http://mapserver.org/development/rfc/ms-rfc-103.html

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Oct 4, 2013

Member

merged, closing

Member

tbonfort commented Oct 4, 2013

merged, closing

@tbonfort tbonfort closed this Oct 4, 2013

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this issue Oct 4, 2013

tbonfort added a commit that referenced this issue Mar 27, 2014

@havatv

This comment has been minimized.

Show comment
Hide comment
@havatv

havatv Apr 4, 2016

Someone forgot that this should have been documented. Has now been discovered and reported in mapserver/docs#146.

havatv commented Apr 4, 2016

Someone forgot that this should have been documented. Has now been discovered and reported in mapserver/docs#146.

havatv pushed a commit to mapserver/docs that referenced this issue Apr 4, 2016

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 4, 2016

Member

👍 Someone thanks you for taking care of this @havatv ;)

Member

tbonfort commented Apr 4, 2016

👍 Someone thanks you for taking care of this @havatv ;)

@havatv

This comment has been minimized.

Show comment
Hide comment
@havatv

havatv Apr 5, 2016

@tbonfort , should label-> encoding be marked as deprecated? In that case, do you have a suggestion for an explanation of why it is being deprecated?

havatv commented Apr 5, 2016

@tbonfort , should label-> encoding be marked as deprecated? In that case, do you have a suggestion for an explanation of why it is being deprecated?

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 5, 2016

Member

@havatv yes it should even be marked as removed in 7.0, although there is some fallback mechanism to understand label->encoding if present. The rationale for moving to LAYER was that the encoding of a dataset affects the whole layer, not only its labels: expression filtering should be done when knowing how the data is encoded, and xml documents (e.g. GetFeature) should be emitted with a converted encoding (the xml doc is utf8, so all of its content must be utf8)

Member

tbonfort commented Apr 5, 2016

@havatv yes it should even be marked as removed in 7.0, although there is some fallback mechanism to understand label->encoding if present. The rationale for moving to LAYER was that the encoding of a dataset affects the whole layer, not only its labels: expression filtering should be done when knowing how the data is encoded, and xml documents (e.g. GetFeature) should be emitted with a converted encoding (the xml doc is utf8, so all of its content must be utf8)

@jmckenna

This comment has been minimized.

Show comment
Hide comment
@jmckenna

jmckenna Apr 8, 2016

Member

@tbonfort currently PHP mapscript has the "encoding" attribute at the LABEL level only. I've checked the 7.0.1 source and it is only available in php/label.c

Swig seems to handle it at the layer level though (in python\mapscript.py).

Member

jmckenna commented Apr 8, 2016

@tbonfort currently PHP mapscript has the "encoding" attribute at the LABEL level only. I've checked the 7.0.1 source and it is only available in php/label.c

Swig seems to handle it at the layer level though (in python\mapscript.py).

@jmckenna

This comment has been minimized.

Show comment
Hide comment
@jmckenna

jmckenna Apr 8, 2016

Member

I confirm that this issues exists with branch-7.0 and master, for PHP mapscript.

Member

jmckenna commented Apr 8, 2016

I confirm that this issues exists with branch-7.0 and master, for PHP mapscript.

jmckenna added a commit to mapserver/docs that referenced this issue Apr 8, 2016

jmckenna added a commit to mapserver/docs that referenced this issue Apr 8, 2016

jmckenna added a commit to mapserver/docs that referenced this issue Apr 8, 2016

jmckenna added a commit to mapserver/docs that referenced this issue Apr 8, 2016

jmckenna added a commit that referenced this issue Apr 13, 2016

@jmckenna

This comment has been minimized.

Show comment
Hide comment
@jmckenna

jmckenna Apr 13, 2016

Member

Fixed PHPmapscript missing layer encoding property through c7fa5aa

Member

jmckenna commented Apr 13, 2016

Fixed PHPmapscript missing layer encoding property through c7fa5aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment