Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A layer using a mask and a label with repeatdistance can crash #4764

Closed
aboudreault opened this issue Sep 25, 2013 · 5 comments
Closed

A layer using a mask and a label with repeatdistance can crash #4764

aboudreault opened this issue Sep 25, 2013 · 5 comments
Assignees
Milestone

Comments

@aboudreault
Copy link
Member

@aboudreault aboudreault commented Sep 25, 2013

A layer using a mask with labels can crash if the label x/y is below 0. This case happens when using repeatdistance. The crash happends in msAddLabel.

@ghost ghost assigned aboudreault Sep 25, 2013
@tbonfort
Copy link
Member

@tbonfort tbonfort commented Sep 25, 2013

@aboudreault I've moved the milestone to 6.2.2, please add to branch-6-2 if you're going to work on it. thanks.

@aboudreault
Copy link
Member Author

@aboudreault aboudreault commented Sep 25, 2013

Yes, I've checked to also set the milestone 6.2.2 but it seems we can't.

aboudreault pushed a commit that referenced this issue Sep 25, 2013
@aboudreault
Copy link
Member Author

@aboudreault aboudreault commented Sep 25, 2013

Thomas, how do you prefer to work? Do you want me to add my patch also in branch-6-4 and master using cherry-pick, or you would like to do some merging?

@tbonfort
Copy link
Member

@tbonfort tbonfort commented Sep 25, 2013

Alan, the recommended way would be to do two merges (6-2 into 6-4, then 6-4 into master). You'll definitely have a small conflict to resolve in the 6-4 to master one.

@aboudreault
Copy link
Member Author

@aboudreault aboudreault commented Sep 25, 2013

Fixed in branch-6-2, branch-6-4 and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.