New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing svg symbol cause assert #4899

Closed
fblackburn opened this Issue Mar 28, 2014 · 4 comments

Comments

Projects
None yet
2 participants
@fblackburn
Contributor

fblackburn commented Mar 28, 2014

Referencing a missing svg file in a symbol definition cause an assert. The assert message says: "mapserv: (mapserver directory)/mapcairo.c:998: msRenderRasterizedSVGSymbol: Assertion `svg_cache->pixmap_buffer->height && svg_cache->pixmap_buffer->width' failed.".

fblackburn added a commit to fblackburn/mapserver that referenced this issue Mar 28, 2014

Fix empty svg assert (#4899)
* Added a return ms_failure when symbol svg file path doesn't point on an existing file
* Removed the assert in the freeSVGCache function of mapcairo.c
@fblackburn

This comment has been minimized.

Show comment
Hide comment
@fblackburn

fblackburn Mar 28, 2014

Contributor

Referenced by pull request #4900

Contributor

fblackburn commented Mar 28, 2014

Referenced by pull request #4900

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Mar 29, 2014

Member

Applied without the unrelated cosmetic changes in 83e4ee8

Member

tbonfort commented Mar 29, 2014

Applied without the unrelated cosmetic changes in 83e4ee8

@tbonfort tbonfort closed this Mar 29, 2014

@tbonfort tbonfort added this to the 6.4.2 release milestone Mar 29, 2014

@tbonfort tbonfort self-assigned this Mar 29, 2014

@tbonfort tbonfort added Bug labels Mar 29, 2014

@fblackburn

This comment has been minimized.

Show comment
Hide comment
@fblackburn

fblackburn Mar 31, 2014

Contributor

Using a mapfile with a missing SVG symbol in it still cause an assert in the "freeSVGCache" function on line 1039 of "mapcairo.c". I realise I did a poor job at explaining the second part of my pull request (#4900) but it was supposed to fix this assert.

Contributor

fblackburn commented Mar 31, 2014

Using a mapfile with a missing SVG symbol in it still cause an assert in the "freeSVGCache" function on line 1039 of "mapcairo.c". I realise I did a poor job at explaining the second part of my pull request (#4900) but it was supposed to fix this assert.

tbonfort added a commit that referenced this issue Apr 1, 2014

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 1, 2014

Member

Sorry, I've added the check in 75a5408 . I'm leaving in the assertion as it would be a bug needing fixing if the renderer_cache came in with a NULL svg handle.

Member

tbonfort commented Apr 1, 2014

Sorry, I've added the check in 75a5408 . I'm leaving in the assertion as it would be a bug needing fixing if the renderer_cache came in with a NULL svg handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment