New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRID setting in mapfile doesn't work as expected #4913

Closed
szekerest opened this Issue Apr 27, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@szekerest
Member

szekerest commented Apr 27, 2014

When I open a map file (with graticule grid) and then draw the map, the grid settings are getting lost because drawlayer closes the layer implicitly and the grid settings are stored in layerinfo (which is the problem primarily).

In order to fix this issue I suggest making the following changes?

  1. add graticuleObj to layerObj (mapserver.h)
  2. load grid settings to layerObj->graticuleObj instead of layerinfo (mapfile.c)
  3. destroy graticuleObj in freeLayer instead of msGraticuleLayerClose
  4. Modify the vtable handlers to use layerObj->graticuleObj instead of layerinfo
  5. copy the relevant settings of graticuleobj in mapcopy.c
  6. Expose graticuleObj in mapscript. (if needed)

@szekerest szekerest self-assigned this Apr 27, 2014

@szekerest

This comment has been minimized.

Show comment
Hide comment
@szekerest

szekerest Apr 27, 2014

Member

These changes would also fix #1980

Member

szekerest commented Apr 27, 2014

These changes would also fix #1980

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort May 3, 2014

Member

closing, implemented

Member

tbonfort commented May 3, 2014

closing, implemented

@tbonfort tbonfort closed this May 3, 2014

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Sep 29, 2015

Member

I very much suspect that this commit is causing #5159 for php mapscript

Member

tbonfort commented Sep 29, 2015

I very much suspect that this commit is causing #5159 for php mapscript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment