Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding large number of errors in msSetError #4960

Closed
szekerest opened this issue Jul 23, 2014 · 2 comments
Closed

Hiding large number of errors in msSetError #4960

szekerest opened this issue Jul 23, 2014 · 2 comments
Assignees

Comments

@szekerest
Copy link
Member

@szekerest szekerest commented Jul 23, 2014

There are certain locations in MapServer were a large number of error can be raised subsequently, which might be annoying if the error is getting displayed to the end user (in a message box for example).

One example for this issue is in msProjectPoint (mapproject.c line 118) which may be raised many times for a polygon or a line string. In the meantime I see that the referred line has been commented out in the master branch, but I don't think if it would be the reasonable solution for this problem, since that error may contain important information for the user.

A trivial solution for this is modifying msSetError to ignore the error if it has already been issued previously.

@szekerest szekerest self-assigned this Jul 23, 2014
szekerest added a commit to szekerest/mapserver that referenced this issue Jul 23, 2014
@dmorissette
Copy link
Contributor

@dmorissette dmorissette commented Jul 23, 2014

Hi @szekerest. I see that your patch counts the number of times the error was repeated and adds that number at the end of the message inside brackets (e.g. "message here (5)"). I think it would be more intuitive to the user if you included the text "(message repeated %d times)" instead.

@szekerest
Copy link
Member Author

@szekerest szekerest commented Jul 23, 2014

@dmorissette Seems reasonable, applying

szekerest added a commit to szekerest/mapserver that referenced this issue Jul 25, 2014
@szekerest szekerest closed this Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.