Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing while reading MapInfo layer with AUTO styleitem #4971

Closed
bx50 opened this issue Aug 14, 2014 · 4 comments
Closed

Crashing while reading MapInfo layer with AUTO styleitem #4971

bx50 opened this issue Aug 14, 2014 · 4 comments

Comments

@bx50
Copy link

@bx50 bx50 commented Aug 14, 2014

Could be solved by:

--- mapfile.c.orig  2014-08-13 14:39:53.000000000 +0200
+++ mapfile.c   2014-08-13 14:40:45.000000000 +0200
@@ -3398,7 +3398,7 @@

   /* reset labels */
   for(i=0; i<class->numlabels; i++) {
-    if(class->styles[i] != NULL) {
+    if(class->labels[i] != NULL) {
       if(freeLabel(class->labels[i]) == MS_SUCCESS ) {
         msFree(class->labels[i]);
       }
@dmorissette
Copy link
Contributor

@dmorissette dmorissette commented Aug 14, 2014

I agree with this fix but am not setup to test and commit it at the moment. Hopefully @tbonfort or another dev can apply it, and possibly backport to the 6.4 stable branch as well.

szekerest added a commit that referenced this issue Aug 14, 2014
@szekerest
Copy link
Member

@szekerest szekerest commented Aug 14, 2014

Fix applied in master and branch-6-4

@dmorissette
Copy link
Contributor

@dmorissette dmorissette commented Aug 14, 2014

Thank you @szekerest

@jratike80
Copy link

@jratike80 jratike80 commented Nov 2, 2015

Fix in included in https://github.com/mapserver/mapserver/blob/branch-7-0/mapfile.c. Nobody has confirmed that the fix prevents crashes but let's hope it does.

@jratike80 jratike80 closed this Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.