New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for RFC 91 #4974

Closed
sdlime opened this Issue Aug 19, 2014 · 11 comments

Comments

Projects
None yet
3 participants
@sdlime
Member

sdlime commented Aug 19, 2014

This is a tracking issue for merging RFC 91 branches into master.

http://mapserver.org/fr/development/rfc/ms-rfc-91.html

@sdlime sdlime added this to the 7.0 Release milestone Aug 19, 2014

@msmitherdc

This comment has been minimized.

Show comment
Hide comment
@msmitherdc

msmitherdc Aug 19, 2014

Contributor

@sdlime looks like node->tokenval.tmval.tm_min is not being populated.

String: (`[TIME]` = `2004-01-01 17:10:00`) OR (`[TIME]` = `2004-01-01 14:10:00`)
msOracleSpatialLayerTranslateFilter. There are tokens to process
Minute value is 0

@msmitherdc -- checking on it... --Steve

Contributor

msmitherdc commented Aug 19, 2014

@sdlime looks like node->tokenval.tmval.tm_min is not being populated.

String: (`[TIME]` = `2004-01-01 17:10:00`) OR (`[TIME]` = `2004-01-01 14:10:00`)
msOracleSpatialLayerTranslateFilter. There are tokens to process
Minute value is 0

@msmitherdc -- checking on it... --Steve

@msmitherdc

This comment has been minimized.

Show comment
Hide comment
@msmitherdc

msmitherdc Aug 19, 2014

Contributor

@sdlime also, the quoting of all identifiers for oracle is creating some backwards incompatibility issues. When quoted, oracle uses the case of identifiers, so users will have up upcase their identifiers. I think we should only quote when the escape ("") character is present.

Contributor

msmitherdc commented Aug 19, 2014

@sdlime also, the quoting of all identifiers for oracle is creating some backwards incompatibility issues. When quoted, oracle uses the case of identifiers, so users will have up upcase their identifiers. I think we should only quote when the escape ("") character is present.

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime Aug 21, 2014

Member

@msmitherdc, I take it you are referring to the msLayerEscapePropertyName() function. I don't think we should monkey with the default version defined in maplayer.c. You should instead create an Oracle specific version that does what you need and register that in the Oracle driver vtable. --Steve

Member

sdlime commented Aug 21, 2014

@msmitherdc, I take it you are referring to the msLayerEscapePropertyName() function. I don't think we should monkey with the default version defined in maplayer.c. You should instead create an Oracle specific version that does what you need and register that in the Oracle driver vtable. --Steve

@msmitherdc

This comment has been minimized.

Show comment
Hide comment
@msmitherdc

msmitherdc Aug 22, 2014

Contributor

@sdlime ok, got the identifier issue worked out.

Contributor

msmitherdc commented Aug 22, 2014

@sdlime ok, got the identifier issue worked out.

tbonfort added a commit to tbonfort/mapserver that referenced this issue Aug 27, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this issue Aug 27, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this issue Aug 27, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this issue Sep 1, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this issue Sep 1, 2014

@msmitherdc

This comment has been minimized.

Show comment
Hide comment
@msmitherdc

msmitherdc Sep 7, 2014

Contributor

@sdlime looks like the CLUSTER keyword doesn't work for me in 7/rfc91. I get these items being treated as columns. This happens with Oracle backend, OGR, and shapefiles.

Error:[Sun Sep 7 07:56:29 2014].44203 msDBFGetItemIndex(): DBASE file error. Item 'Cluster:FeatureCount' not found.

Example layer definition:

LAYER
  NAME eq_cluster
  TYPE POINT
  STATUS off
  EXTENT -179.987600 -61.325200 179.976100 74.552100
  #CONNECTIONTYPE OGR
  #CONNECTION "earthquakes.db"
  #DATA "grid.earthquakes"
  DATA "earthquakes.shp"
  CLASSITEM "Cluster:FeatureCount"
  LABELITEM "Cluster:FeatureCount"
  PROJECTION
    "init=epsg:4326"
  END
  CLUSTER
    MAXDISTANCE 50
    REGION "ellipse"
  END
  CLASS
    NAME "Earthquakes-cluster"
    EXPRESSION ("[Cluster:FeatureCount]" != "1")
    STYLE
      SYMBOL "circle"
      SIZE 50
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
    CLASS
    NAME "Earthquakes-single"
    EXPRESSION "1"
    STYLE
      SYMBOL "circle"
      SIZE 18
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
  END
  UNITS PIXELS
  TOLERANCE 10
END # layer
Contributor

msmitherdc commented Sep 7, 2014

@sdlime looks like the CLUSTER keyword doesn't work for me in 7/rfc91. I get these items being treated as columns. This happens with Oracle backend, OGR, and shapefiles.

Error:[Sun Sep 7 07:56:29 2014].44203 msDBFGetItemIndex(): DBASE file error. Item 'Cluster:FeatureCount' not found.

Example layer definition:

LAYER
  NAME eq_cluster
  TYPE POINT
  STATUS off
  EXTENT -179.987600 -61.325200 179.976100 74.552100
  #CONNECTIONTYPE OGR
  #CONNECTION "earthquakes.db"
  #DATA "grid.earthquakes"
  DATA "earthquakes.shp"
  CLASSITEM "Cluster:FeatureCount"
  LABELITEM "Cluster:FeatureCount"
  PROJECTION
    "init=epsg:4326"
  END
  CLUSTER
    MAXDISTANCE 50
    REGION "ellipse"
  END
  CLASS
    NAME "Earthquakes-cluster"
    EXPRESSION ("[Cluster:FeatureCount]" != "1")
    STYLE
      SYMBOL "circle"
      SIZE 50
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
    CLASS
    NAME "Earthquakes-single"
    EXPRESSION "1"
    STYLE
      SYMBOL "circle"
      SIZE 18
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
  END
  UNITS PIXELS
  TOLERANCE 10
END # layer
@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime Sep 7, 2014

Member

Expressions should be unaffected by RFC 91 although there were some modest changes to msWhichItems(). Can you post the full mapfile.

Steve


From: Michael D. Smith [notifications@github.com]
Sent: Sunday, September 07, 2014 6:58 AM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] Tracking issue for RFC 91 (#4974)

@sdlimehttps://github.com/sdlime looks like the CLUSTER keyword doesn't work for me in 7/rfc91. I get these items being treated as columns. This happens with Oracle backend, OGR, and shapefiles.

Error:[Sun Sep 7 07:56:29 2014].44203 msDBFGetItemIndex(): DBASE file error. Item 'Cluster:FeatureCount' not found.

Example layer definition:

LAYER
NAME eq_cluster
TYPE POINT
STATUS off
EXTENT -179.987600 -61.325200 179.976100 74.552100
#CONNECTIONTYPE OGR
#CONNECTION "earthquakes.db"
#DATA "grid.earthquakes"
DATA "earthquakes.shp"
CLASSITEM "Cluster:FeatureCount"
LABELITEM "Cluster:FeatureCount"
PROJECTION
"init=epsg:4326"
END
CLUSTER
MAXDISTANCE 50
REGION "ellipse"
END
CLASS
NAME "Earthquakes-cluster"
EXPRESSION ("[Cluster:FeatureCount]" != "1")
STYLE
SYMBOL "circle"
SIZE 50
COLOR 255 140 0
OUTLINECOLOR 0 0 0
END
CLASS
NAME "Earthquakes-single"
EXPRESSION "1"
STYLE
SYMBOL "circle"
SIZE 18
COLOR 255 140 0
OUTLINECOLOR 0 0 0
END
END
UNITS PIXELS
TOLERANCE 10
END # layer


Reply to this email directly or view it on GitHubhttps://github.com/mapserver/mapserver/issues/4974#issuecomment-54744677.

Member

sdlime commented Sep 7, 2014

Expressions should be unaffected by RFC 91 although there were some modest changes to msWhichItems(). Can you post the full mapfile.

Steve


From: Michael D. Smith [notifications@github.com]
Sent: Sunday, September 07, 2014 6:58 AM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] Tracking issue for RFC 91 (#4974)

@sdlimehttps://github.com/sdlime looks like the CLUSTER keyword doesn't work for me in 7/rfc91. I get these items being treated as columns. This happens with Oracle backend, OGR, and shapefiles.

Error:[Sun Sep 7 07:56:29 2014].44203 msDBFGetItemIndex(): DBASE file error. Item 'Cluster:FeatureCount' not found.

Example layer definition:

LAYER
NAME eq_cluster
TYPE POINT
STATUS off
EXTENT -179.987600 -61.325200 179.976100 74.552100
#CONNECTIONTYPE OGR
#CONNECTION "earthquakes.db"
#DATA "grid.earthquakes"
DATA "earthquakes.shp"
CLASSITEM "Cluster:FeatureCount"
LABELITEM "Cluster:FeatureCount"
PROJECTION
"init=epsg:4326"
END
CLUSTER
MAXDISTANCE 50
REGION "ellipse"
END
CLASS
NAME "Earthquakes-cluster"
EXPRESSION ("[Cluster:FeatureCount]" != "1")
STYLE
SYMBOL "circle"
SIZE 50
COLOR 255 140 0
OUTLINECOLOR 0 0 0
END
CLASS
NAME "Earthquakes-single"
EXPRESSION "1"
STYLE
SYMBOL "circle"
SIZE 18
COLOR 255 140 0
OUTLINECOLOR 0 0 0
END
END
UNITS PIXELS
TOLERANCE 10
END # layer


Reply to this email directly or view it on GitHubhttps://github.com/mapserver/mapserver/issues/4974#issuecomment-54744677.

@msmitherdc

This comment has been minimized.

Show comment
Hide comment
@msmitherdc

msmitherdc Sep 7, 2014

Contributor

Full mapfile

MAP
NAME "earthquakes-cluster"
STATUS ON
SIZE 1000 800
SYMBOLSET "../etc/symbols.txt"
EXTENT -180 -90 180 90
UNITS DD
SHAPEPATH "../data"
IMAGECOLOR 255 255 255
FONTSET "../etc/fonts.txt"

WEB
  IMAGEPATH "/ms4w/tmp/ms_tmp/" 
  IMAGEURL "/ms_tmp/"
END

PROJECTION
  "init=epsg:4326"
END

#
# Start of layer definitions
#

LAYER
  NAME 'global-raster'
  TYPE RASTER
  DATA "./GLOBALeb3colshade.jpg"
  STATUS DEFAULT
  CLASS
    NAME 'Earth Image' 
  END
  PROJECTION
    "init=epsg:4326"
  END  
END

LAYER
  NAME "earthquakes-cluster"
  TYPE POINT
  STATUS DEFAULT
  EXTENT -179.987600 -61.325200 179.976100 74.552100
  CONNECTIONTYPE OGR
  CONNECTION "earthquakes.db"
  DATA "grid.earthquakes"
  CLASSITEM "Cluster:FeatureCount"
  LABELITEM "Cluster:FeatureCount"
  PROJECTION
    "init=epsg:4326"
  END
  ###########################
  # Define the cluster object
  ###########################
  CLUSTER
    MAXDISTANCE 50
    REGION "ellipse"
  END  
  #Return all shapes when querying
  PROCESSING "CLUSTER_GET_ALL_SHAPES"
  CLASS
    NAME "Earthquakes-cluster"
    EXPRESSION ("[Cluster:FeatureCount]" != "1")
    #EXPRESSION ("[Cluster:FeatureCount]" > "50")
    STYLE
      SYMBOL "circle"
      SIZE 50
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
    LABEL
      FONT sans
      TYPE TRUETYPE
      SIZE 8
      COLOR 120 120 120
      ALIGN CENTER
      PRIORITY 10
      BUFFER 1
      PARTIALS TRUE
      POSITION cc
    END     
  END 
  CLASS
    NAME "Earthquakes-single"
    EXPRESSION "1"
    STYLE
      SYMBOL "circle"
      SIZE 18
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END    
  END  
  UNITS PIXELS
  TOLERANCE 10  
END # layer



END # Map File
Contributor

msmitherdc commented Sep 7, 2014

Full mapfile

MAP
NAME "earthquakes-cluster"
STATUS ON
SIZE 1000 800
SYMBOLSET "../etc/symbols.txt"
EXTENT -180 -90 180 90
UNITS DD
SHAPEPATH "../data"
IMAGECOLOR 255 255 255
FONTSET "../etc/fonts.txt"

WEB
  IMAGEPATH "/ms4w/tmp/ms_tmp/" 
  IMAGEURL "/ms_tmp/"
END

PROJECTION
  "init=epsg:4326"
END

#
# Start of layer definitions
#

LAYER
  NAME 'global-raster'
  TYPE RASTER
  DATA "./GLOBALeb3colshade.jpg"
  STATUS DEFAULT
  CLASS
    NAME 'Earth Image' 
  END
  PROJECTION
    "init=epsg:4326"
  END  
END

LAYER
  NAME "earthquakes-cluster"
  TYPE POINT
  STATUS DEFAULT
  EXTENT -179.987600 -61.325200 179.976100 74.552100
  CONNECTIONTYPE OGR
  CONNECTION "earthquakes.db"
  DATA "grid.earthquakes"
  CLASSITEM "Cluster:FeatureCount"
  LABELITEM "Cluster:FeatureCount"
  PROJECTION
    "init=epsg:4326"
  END
  ###########################
  # Define the cluster object
  ###########################
  CLUSTER
    MAXDISTANCE 50
    REGION "ellipse"
  END  
  #Return all shapes when querying
  PROCESSING "CLUSTER_GET_ALL_SHAPES"
  CLASS
    NAME "Earthquakes-cluster"
    EXPRESSION ("[Cluster:FeatureCount]" != "1")
    #EXPRESSION ("[Cluster:FeatureCount]" > "50")
    STYLE
      SYMBOL "circle"
      SIZE 50
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END
    LABEL
      FONT sans
      TYPE TRUETYPE
      SIZE 8
      COLOR 120 120 120
      ALIGN CENTER
      PRIORITY 10
      BUFFER 1
      PARTIALS TRUE
      POSITION cc
    END     
  END 
  CLASS
    NAME "Earthquakes-single"
    EXPRESSION "1"
    STYLE
      SYMBOL "circle"
      SIZE 18
      COLOR 255 140 0
      OUTLINECOLOR 0 0 0
    END    
  END  
  UNITS PIXELS
  TOLERANCE 10  
END # layer



END # Map File
@msmitherdc

This comment has been minimized.

Show comment
Hide comment
@msmitherdc

msmitherdc Sep 7, 2014

Contributor

@sdlime link with data etc http://1drv.ms/1rqq1D7

Contributor

msmitherdc commented Sep 7, 2014

@sdlime link with data etc http://1drv.ms/1rqq1D7

@msmitherdc

This comment has been minimized.

Show comment
Hide comment
@msmitherdc

msmitherdc Sep 8, 2014

Contributor

@sdlime ok, there is no issue with clusters, its a documentation issue. with (szekerest@794cdcc) the syntax was changed from using a colon (:) to an underscore (_). And thats not in the docs. I'll open a doc ticket about it.

Contributor

msmitherdc commented Sep 8, 2014

@sdlime ok, there is no issue with clusters, its a documentation issue. with (szekerest@794cdcc) the syntax was changed from using a colon (:) to an underscore (_). And thats not in the docs. I'll open a doc ticket about it.

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime Sep 8, 2014

Member

Whew...


From: Michael D. Smith [notifications@github.com]
Sent: Sunday, September 07, 2014 11:26 PM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] Tracking issue for RFC 91 (#4974)

@sdlimehttps://github.com/sdlime ok, there is no issue with clusters, its a documentation issue. with (szekerest@794cdcchttps://github.com/szekerest/mapserver/commit/794cdcc64620d2c1958bfede5ec1c5424c0592de) the syntax was changes from using a colon (:) to an underscore (_). And thats not in the docs. I'll open a doc ticket about it.


Reply to this email directly or view it on GitHubhttps://github.com/mapserver/mapserver/issues/4974#issuecomment-54775760.

Member

sdlime commented Sep 8, 2014

Whew...


From: Michael D. Smith [notifications@github.com]
Sent: Sunday, September 07, 2014 11:26 PM
To: mapserver/mapserver
Cc: Lime, Steve D (MNIT)
Subject: Re: [mapserver] Tracking issue for RFC 91 (#4974)

@sdlimehttps://github.com/sdlime ok, there is no issue with clusters, its a documentation issue. with (szekerest@794cdcchttps://github.com/szekerest/mapserver/commit/794cdcc64620d2c1958bfede5ec1c5424c0592de) the syntax was changes from using a colon (:) to an underscore (_). And thats not in the docs. I'll open a doc ticket about it.


Reply to this email directly or view it on GitHubhttps://github.com/mapserver/mapserver/issues/4974#issuecomment-54775760.

tbonfort added a commit to tbonfort/mapserver that referenced this issue Sep 18, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this issue Sep 18, 2014

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this issue Sep 18, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this issue Sep 18, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this issue Sep 19, 2014

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

FLTGetSpatialComparisonCommonExpression(): use polygon instead of rec…
…tangle (#4974)

* Reprojection of BBOX to layer SRS should be done as a rectangle to avoid capturing
too many features. Improves wfsogr10_twolayer.xml
* Also add a hack from -180,-90,180,90 BBOX when reprojecting to a projected SRS.

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

rouault added a commit to rouault/mapserver that referenced this issue Sep 20, 2014

Fix post RFC91 issues in mapogcsld.c (#4974)
Make following tests to pass : wms_get_map_sld_proj.png,
wms_get_map_multi_polygon_filter.png, wms_get_map_multi_polygon_filter_postgis.png

sdlime added a commit that referenced this issue Feb 10, 2015

Merge pull request #5000 from rouault/fix_rfc91_sld
Fix post RFC91 issues in mapogcsld.c (#4974)
@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 12, 2015

Member

We can close this one now, yay!

Member

tbonfort commented Feb 12, 2015

We can close this one now, yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment