New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect value for LABELITEM generates a server error instead of an error message. #5188

Closed
sdlime opened this Issue Oct 29, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@sdlime
Member

sdlime commented Oct 29, 2015

In version 7.0, setting a layer LABELITEM to a column name that doesn't exist generates a server error instead of an error message. In 6.4 and earlier versions you'd see something like "msDrawMap(): Image handling error. Failed to draw layer named 'x'. msDBFGetItemIndex(): DBASE file error. Item 'y' not found.".

Steve

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime Oct 29, 2015

Member

Also happens CLASSITEM or within an expression, at least for shapefiles. OGR driver seems to ignore the problem but doesn't crash. Looks like it could be an issue in mapdraw.c where the return value from msLayerWhichItems() is not checked in msDrawVectorLayer().

Member

sdlime commented Oct 29, 2015

Also happens CLASSITEM or within an expression, at least for shapefiles. OGR driver seems to ignore the problem but doesn't crash. Looks like it could be an issue in mapdraw.c where the return value from msLayerWhichItems() is not checked in msDrawVectorLayer().

sdlime added a commit that referenced this issue Oct 29, 2015

sdlime added a commit that referenced this issue Oct 29, 2015

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime Oct 29, 2015

Member

Fixed in branch-7-0 and master. Closing... --Steve

Member

sdlime commented Oct 29, 2015

Fixed in branch-7-0 and master. Closing... --Steve

@sdlime sdlime closed this Oct 29, 2015

@tbonfort tbonfort added this to the 7.0.1 milestone Feb 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment