New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Layers Failing with 7.0 Filter Translation #5205

Closed
tbonfort opened this Issue Dec 4, 2015 · 7 comments

Comments

Projects
None yet
5 participants
@tbonfort
Member

tbonfort commented Dec 4, 2015

The hijacking of layer->layerinfo by the clustering code is making requests after msLayerOpen to anything filter related fail due to that member being of the wrong type:

==14061== Conditional jump or move depends on uninitialised value(s)
==14061==    at 0x4F12E32: msPostGISParseData (mappostgis.c:1354)
==14061==    by 0x4F17D70: msPostGISLayerTranslateFilter (mappostgis.c:3642)
==14061==    by 0x4F4649B: msLayerTranslateFilter (maplayer.c:269)
==14061==    by 0x4F464E7: msLayerWhichShapes (maplayer.c:285)
==14061==    by 0x4F77E3F: msDrawVectorLayer (mapdraw.c:952)
==14061==    by 0x4F77517: msDrawLayer (mapdraw.c:795)
==14061==    by 0x4F75FE6: msDrawMap (mapdraw.c:384)
==14061==    by 0x4EC1F7D: msWMSGetMap (mapwms.c:3672)
==14061==    by 0x4EC71DB: msWMSDispatch (mapwms.c:5023)
==14061==    by 0x4ED9BD0: msOWSDispatch (mapows.c:286)
==14061==    by 0x4EE76E0: msCGIDispatchRequest (mapservutil.c:1712)
==14061==    by 0x40126F: main (mapserv.c:275)

this results in a segfault.

We also still have absolutely no autotests covering anything CLUSTER related, which is a pity because they would have caught that error...

@Manfred73

This comment has been minimized.

Show comment
Hide comment
@Manfred73

Manfred73 May 10, 2016

Is this something that will be fixed in a future version? I found this posting: http://comments.gmane.org/gmane.comp.gis.mapserver.user/54973
and I'm running into the same issue.

Manfred73 commented May 10, 2016

Is this something that will be fixed in a future version? I found this posting: http://comments.gmane.org/gmane.comp.gis.mapserver.user/54973
and I'm running into the same issue.

@dnltsk

This comment has been minimized.

Show comment
Hide comment
@dnltsk

dnltsk commented May 11, 2016

+1

@ErtanMG

This comment has been minimized.

Show comment
Hide comment
@ErtanMG

ErtanMG commented May 12, 2016

+2

szekerest added a commit to szekerest/mapserver that referenced this issue May 13, 2016

szekerest added a commit that referenced this issue May 13, 2016

Merge pull request #5279 from szekerest/clusterfix
Fix Cluster Layers Filter Translation (#5205)
@szekerest

This comment has been minimized.

Show comment
Hide comment
@szekerest

szekerest May 13, 2016

Member

Fix is in branch-7-0

Member

szekerest commented May 13, 2016

Fix is in branch-7-0

@Manfred73

This comment has been minimized.

Show comment
Hide comment
@Manfred73

Manfred73 Jun 13, 2016

We are using a docker image of mapserver7 which is based on the master repository: https://github.com/pamtrak06/mapserver7-ubuntu14.04

Will this fix also be merged to master?

Manfred73 commented Jun 13, 2016

We are using a docker image of mapserver7 which is based on the master repository: https://github.com/pamtrak06/mapserver7-ubuntu14.04

Will this fix also be merged to master?

rouault added a commit that referenced this issue Jun 15, 2016

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Aug 27, 2016

Member

@Manfred73 it will make it's way in soon

Member

tbonfort commented Aug 27, 2016

@Manfred73 it will make it's way in soon

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Aug 27, 2016

Member

let's close this one now, new issues about cluster+filter translations can be openened in new issues

Member

tbonfort commented Aug 27, 2016

let's close this one now, new issues about cluster+filter translations can be openened in new issues

@tbonfort tbonfort closed this Aug 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment