New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapfile.c: hashTableSubstituteString leaks memory #5325

Closed
gogglesguy opened this Issue Sep 14, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@gogglesguy
Contributor

gogglesguy commented Sep 14, 2016

For the line:

msInsertHashTable(hash, key, msCaseReplaceSubstring(msStrdup(val), from, to));

The result of msCaseReplaceSubstring is never freed. HashTable stores a copy of it.

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Sep 14, 2016

Member

Can you create a pull request/patch for this please ?

Member

tbonfort commented Sep 14, 2016

Can you create a pull request/patch for this please ?

@gogglesguy

This comment has been minimized.

Show comment
Hide comment
Contributor

gogglesguy commented Sep 14, 2016

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Sep 14, 2016

Member

Perfect! If you want your name in the commit logs create a pr with that, if not i'll apply myself. Thanks.

Member

tbonfort commented Sep 14, 2016

Perfect! If you want your name in the commit logs create a pr with that, if not i'll apply myself. Thanks.

@gogglesguy

This comment has been minimized.

Show comment
Hide comment
@gogglesguy

gogglesguy Sep 14, 2016

Contributor

Just apply it!

Contributor

gogglesguy commented Sep 14, 2016

Just apply it!

tbonfort added a commit that referenced this issue Sep 15, 2016

tbonfort added a commit that referenced this issue Sep 15, 2016

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Sep 15, 2016

Member

applied to branch-7-0, thanks @gogglesguy

Member

tbonfort commented Sep 15, 2016

applied to branch-7-0, thanks @gogglesguy

@tbonfort tbonfort closed this Sep 15, 2016

@tbonfort tbonfort added this to the 7.0.2 Release milestone Sep 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment