Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Map Size too small #5349

Closed
geographika opened this issue Nov 16, 2016 · 6 comments
Closed

Default Map Size too small #5349

geographika opened this issue Nov 16, 2016 · 6 comments

Comments

@geographika
Copy link
Member

@geographika geographika commented Nov 16, 2016

Currently the maximum image size default is set to 2048 pixels. With increasingly large monitors and higher resolutions I keep hitting this limit when maximising browser windows, and getting an error message.

It is confusing to new users, and requires having to always add a MAXSIZE 4096 line to each new map file.

I'd propose increasing the default to 4096. Users concerned about increased stress on their servers are more likely to know how to change this setting, than new users getting an error.

I believe it should be a case of simply increasing the following?

#define MS_MAXIMAGESIZE_DEFAULT 2048

https://github.com/mapserver/mapserver/blob/66309eebb7ba0dc70469efeb40f865a8e88fafbd/mapserver.h#L262

It was last updated in 2003 - so hopefully most hardware has been updated since then..

@dmorissette
Copy link
Contributor

@dmorissette dmorissette commented Nov 17, 2016

I agree with your logic and would be +1 on increasing the default. Let's see what other devs think.

@tomkralidis
Copy link
Member

@tomkralidis tomkralidis commented Nov 17, 2016

+1, it's time.

@jmckenna
Copy link
Member

@jmckenna jmckenna commented Nov 17, 2016

+1 fully agree

@jmckenna
Copy link
Member

@jmckenna jmckenna commented Dec 1, 2016

Thanks @geographika !

(also filed a docs ticket for this: MapServer/MapServer-documentation/issues/162 )

@jmckenna
Copy link
Member

@jmckenna jmckenna commented Dec 1, 2016

also updated the related msautotest files.

@jmckenna
Copy link
Member

@jmckenna jmckenna commented Dec 9, 2016

docs updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.