New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cascaded WMS] regression between 7.0.4 and 7.0.5 #5445

Closed
pmauduit opened this Issue Jun 5, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@pmauduit
Contributor

pmauduit commented Jun 5, 2017

A customer reported a regression with WMS cascading: the output is not the same for the same request (same mapfile, same parameters, the underlying WMS did not change between both tests).

Below is the query string used:

QUERY_STRING="map=/usr/src/mapfile/wms_recopesca.map&BBOX=-7.21916,48.40401621621622,-3.4696399999999996,50.43078378378378&SERVICE=WMS&REQUEST=GetMap&FORMAT=image/png&styles=&layers=continent&width=1000&height=541&srs=EPSG:4326&EXCEPTIONS=application/vnd.ogc.se_inimage&TRANSPARENT=TRUE&VERSION=1.1.1"

Below, the underlying mapfile extract for the queried layer:

LAYER
        NAME            "continent"
 
	PROJECTION
		"init=epsg:3395"
	END

	EXTENT -20037508.3428 -15496570.7397 20037508.3428 18764656.2314
 
        TYPE            RASTER
 
	CONNECTION		"http://www.ifremer.fr/services/wms1?"
        CONNECTIONTYPE  WMS
 
        STATUS          OFF
        DUMP            FALSE
        METADATA
                "wms_name"              "continent"
                "wms_title"             "continent"
		"wms_srs"		"EPSG:3395"
		"wms_server_version"	"1.1.1"
		"wms_format"          "image/png"
                "queryable"             "false"
        END 
END

And here is the result after having compiled against the 7.0.4 tag:
out-ms-7 0 4-sources

The same for 7.0.5:

out-ms-7 0 5-sources

(Notice the offset between both results with the scalebar)

I first tcpdump'ed the HTTP traffic, and checked that both queries in both versions where producing the same WMS request on the cascaded WMS.

My next try has been to recompile a 7.0.5 tag but after having checked out the 7.0.4 version of the mapresample.c source file, and I obtained the expected image. Hence, the regression is likely isolated to this source file (I suspect the msResampleGDALToMap() function).

@rouault you seem to be the last one having touched the file relying on the git history, any idea of what is going wrong here ?

rouault added a commit to rouault/mapserver that referenced this issue Jun 14, 2017

msResampleGDALToMap(): restrict fix done for #1715, to avoid regressi…
…ons like #5445

mapserver@026847b
introduced a post correction of the source geotransform so that it matches the
sSrcExtent exactly. However the condition for this to make sense is that the
initial geotransform has square pixels.

rouault added a commit that referenced this issue Jun 14, 2017

Merge pull request #5447 from rouault/fix_5445
msResampleGDALToMap(): restrict fix done for #1715, to avoid regressions like #5445
@rouault

This comment has been minimized.

Show comment
Hide comment
@rouault

rouault Jun 14, 2017

Contributor

Fixed per #5447 : merged in branch-7-0 and master

Contributor

rouault commented Jun 14, 2017

Fixed per #5447 : merged in branch-7-0 and master

@rouault rouault closed this Jun 14, 2017

@pmauduit

This comment has been minimized.

Show comment
Hide comment
@pmauduit

pmauduit Jun 14, 2017

Contributor

thanks @rouault !

Contributor

pmauduit commented Jun 14, 2017

thanks @rouault !

rouault added a commit that referenced this issue Jun 14, 2017

szekerest added a commit to DMS-Aus/MapServer that referenced this issue Oct 8, 2017

msResampleGDALToMap(): restrict fix done for #1715, to avoid regressi…
…ons like #5445

mapserver@026847b
introduced a post correction of the source geotransform so that it matches the
sSrcExtent exactly. However the condition for this to make sense is that the
initial geotransform has square pixels.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment