Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFS server filter parameter using <ogc:GmlObjectId> or <ogc:ResourceId> doesn't like feature type name containing dots #5741

Closed
kvlahrogut opened this issue Jan 31, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@kvlahrogut
Copy link

commented Jan 31, 2019

System:

  • SUSE Linux Enterprise Server 12 Service Pack 4
  • x86_64
  • Kernel 4.12.14-95.3
  • MapServer 7.2.1 (OUTPUT=PNG OUTPUT=JPEG OUTPUT=KML SUPPORTS=PROJ SUPPORTS=AGG SUPPORTS=FREETYPE SUPPORTS=CAIRO SUPPORTS=SVG_SYMBOLS SUPPORTS=RSVG SUPPORTS=ICONV SUPPORTS=WMS_SERVER SUPPORTS=WMS_CLIENT SUPPORTS=WFS_SERVER SUPPORTS=WFS_CLIENT SUPPORTS=WCS_SERVER SUPPORTS=SOS_SERVER SUPPORTS=FASTCGI SUPPORTS=GEOS SUPPORTS=PBF INPUT=JPEG INPUT=POSTGIS INPUT=OGR INPUT=GDAL INPUT=SHAPEFILE)

Description:
Thanks to the fix implemented to solve issue #4925, we can have feature type names containing dots and WFS server parameter featureid, however, works perfectly well. The GET request …

https://geo.sv.rostock.de/geodienste/schulen/wfs?service=WFS&version=1.1.0&request=GetFeature&typename=schulen:hro.schulen.grundschulen&featureid=hro.schulen.grundschulen.0ac5533c-cd47-11e4-b1ea-0050569b7e95

… for example returns exactly the feature we want it to return: the feature with id 0ac5533c-cd47-11e4-b1ea-0050569b7e95 of the feature type hro.schulen.grundschulen.

But: If we change the link so that it uses WFS server parameter filter with <ogc:GmlObjectId> instead of featureid

https://geo.sv.rostock.de/geodienste/schulen/wfs?service=WFS&version=1.1.0&request=GetFeature&typename=schulen:hro.schulen.grundschulen&filter=<ogc:Filter><ogc:GmlObjectId gml:id="hro.schulen.grundschulen.0ac5533c-cd47-11e4-b1ea-0050569b7e95"/></ogc:Filter>

… MapServer throws an exception:

FLTPreParseFilterForAlias(): General error message. Feature id hro.schulen.grundschulen.0ac5533c-cd47-11e4-b1ea-0050569b7e95 not consistent with feature type name hro.schulen.grundschulen.

By the way: exactly the same behaviour with <ogc:ResourceId> (FE 2.0 using WFS version 2.0.0).

And since WFS server parameter filter with <ogc:GmlObjectId> works like a charm, too, if we change feature type name hro.schulen.grundschulen to something like, for instance, hro_schulen_grundschulen, there seems to be something wrong with MapServer's parsing of gml:id="…" if the feature type name is containing dots.

@kvlahrogut kvlahrogut changed the title WFS server filter parameter using <ogc:GmlObjectId> doesn't like feature type name containing dots WFS server filter parameter using <ogc:GmlObjectId> or <ogc:ResourceId> doesn't like feature type name containing dots Jan 31, 2019

@kvlahrogut

This comment has been minimized.

Copy link
Author

commented Jan 31, 2019

Maybe having a closer look at the function …

int FLTCheckFeatureIdFilters(FilterEncodingNode *psFilterNode,

… would lead to a possible solution.

@ravhed

This comment has been minimized.

Copy link
Contributor

commented May 6, 2019

I believe this issue can be closed now since the fix is merged into branch-7.4. Github says it will "close once commit b8139f2 is merged into the 'branch-7.4' branch'" but seems like it didn't do it for some reason. Can you close it @geographika?

@geographika

This comment has been minimized.

Copy link
Member

commented May 6, 2019

@kvlahrogut - if you get a chance to confirm the issue is fixed in your example (using the latest 7.4 release candidate) that would be helpful. Please reopen the issue if it is not.

@geographika geographika closed this May 6, 2019

@kvlahrogut

This comment has been minimized.

Copy link
Author

commented May 6, 2019

@ravhed – Thank you very much for the fix! @geographika – I can confirm that feature names with dots are now supported for feature id filtering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.