Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oracle Spatial latest OCI requires adding libnnz18 to the FindOracle.cmake script #5796

Closed
bmulcahy opened this issue Apr 25, 2019 · 3 comments

Comments

@bmulcahy
Copy link
Contributor

commented Apr 25, 2019

Line 40 of the mapserver/cmakeFindOracle.cmake macro needs to have an additional file name added to support the latest Instant Client which uses libnnz18 and not libnnz12

set(ORACLE_NNZ_NAMES nnz10 libnnz10 nnz11 libnnz11 nnz12 libnnz12 ociw32)

to

set(ORACLE_NNZ_NAMES nnz10 libnnz10 nnz11 libnnz11 nnz12 libnnz12 nnz18 libnnz18 ociw32)
@bmulcahy

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Another option would be to add to the OCI plugin documentation to create a symbolic link for the libnnz18( or any future version number) to a generic libnnz name. That way you don't have to update the source code for each new iteration of the OCI library files. I can provide a pull request for either one. Thoughts?

@jmckenna

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

I'm not sure how your second option would work for all versions. However a pull request for either option is encouraged :)

bmulcahy added a commit to bmulcahy/mapserver that referenced this issue Jun 12, 2019

Issue mapserver#5796 - Latest OCI library files not found
Added version specific libnnz name to the ORACLE_NNZ_NAMES list

jmckenna added a commit that referenced this issue Jun 12, 2019

Merge pull request #5820 from bmulcahy/patch-1
Issue #5796 - Latest OCI library files not found
@jmckenna

This comment has been minimized.

Copy link
Member

commented Jun 12, 2019

Merged into master and branch-7-4 Thanks @bmulcahy

@jmckenna jmckenna closed this Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.