Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake/FindProj.cmake still looks for proj_api.h ? #6249

Closed
landryb opened this issue Mar 8, 2021 · 0 comments
Closed

cmake/FindProj.cmake still looks for proj_api.h ? #6249

landryb opened this issue Mar 8, 2021 · 0 comments
Milestone

Comments

@landryb
Copy link
Contributor

landryb commented Mar 8, 2021

https://github.com/MapServer/MapServer/blob/main/cmake/FindProj.cmake#L9 still looks for proj_api.h to detect the presence of proj, this will fail with proj 8 which removed the header.

simply looking for proj.h seems to be enough for 7.6.2 to properly detect proj 8 presence.

-- Found PROJ: /usr/local/lib/libproj.so.16.0  
-- Found Proj 8.0

i guess this was forgotten in #5766..

--- cmake/FindProj.cmake.orig
+++ cmake/FindProj.cmake
@@ -6,7 +6,7 @@
 #    PROJ_LIBRARY
 
 
-FIND_PATH(PROJ_INCLUDE_DIR proj_api.h)
+FIND_PATH(PROJ_INCLUDE_DIR proj.h)
 
 FIND_LIBRARY(PROJ_LIBRARY NAMES proj proj_i)
 
bob-beck pushed a commit to openbsd/ports that referenced this issue Mar 8, 2021
check for the presence of proj.h instead of proj_api.h, the latter is
removed in proj 8.
reported upstream at MapServer/MapServer#6249
rouault added a commit to rouault/mapserver that referenced this issue Mar 8, 2021
@jmckenna jmckenna added this to the 8.0 Release milestone Mar 8, 2021
@rouault rouault closed this as completed in e56a020 Mar 8, 2021
rouault added a commit that referenced this issue Mar 8, 2021
FindProj.cmake: allow finding PROJ 8 that has no longer proj_api.h (fixes #6249)
@rouault rouault modified the milestones: 8.0 Release, 7.6.3 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants