Correct wgs84 bbox in WFS GetCapabilties #4499

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@mkofahl
Contributor
mkofahl commented Oct 18, 2012

For layers having another source datum than wgs84 the wgs84 bbox is currently wrong in the WFS getcapabilties document. Compared to the WMS server code, the datum wasn't set in msProjectRect(). fixes #4498

@tbonfort
Member

@mkofahl can you check that the failing tests are what's expected and that they can be updated? There seems to be an issue with some of them, the bounding rect having changed from a box to a point.

@mkofahl mkofahl pushed a commit to faegi/mapserver that referenced this pull request Oct 20, 2012
Martin Kofahl resolve double reprojection to wgs84 for wfs 1.1.0 latlong boxes intr…
…oduced in commit b9fb45e

refs #4499
6b926ac
@mkofahl
Contributor
mkofahl commented Oct 20, 2012

@tbonfort In some cases coordinates were projected to wgs84 twice. Fixed. The new ows:WGS84BoundingBox for layer multi in msautotest/wxs/expected/wfsogr11_caps.xml looks fine and is in line with the bbox generated from the wms code using that layer definition.

@tbonfort
Member

@mapserver-bot retest this please

@tbonfort
Member

@mkofahl there's still a failing test (c.f. http://ci.mapserver.org/job/mapserverpullrequests/66/console at the end of the page for the diff). Can you check wether the test needs updating or wether it's an issue with the patch ? Also, should this go to master or 6.2 ?

@mkofahl
Contributor
mkofahl commented Dec 14, 2012

@tbonfort Test results needs to be updated. But doing the transformation with ogr2ogr I do get coordinates which neither goes with those in the expected results nor with this patch. Will try to get the reason for it soon.

@mkofahl mkofahl pushed a commit to faegi/mapserver that referenced this pull request Dec 19, 2012
Martin Kofahl + faegi resolve double reprojection to wgs84 for wfs 1.1.0 latlong boxes intr…
…oduced in commit b9fb45e

refs #4499
2af48bf
@mkofahl
Contributor
mkofahl commented Mar 22, 2013

msautotest corrected at mapserver/msautotest_DEPRECATED#15

@mkofahl mkofahl referenced this pull request in mapserver/msautotest_DEPRECATED Mar 22, 2013
Closed

Corrected coordinate transformation results #15

@mkofahl mkofahl was assigned Mar 22, 2013
@mkofahl
Contributor
mkofahl commented Mar 22, 2013

@tbonfort Are you ok with msOWSProjectToWGS84 having hard coded proj4 parameters?

@tbonfort
Member

@mkofahl I have no idea of what the implications would be. Maybe @dmorissette can comment ?

@tbonfort
Member

rebased and applied in 23f61d0

@tbonfort tbonfort closed this Mar 29, 2013
@mkofahl mkofahl added a commit to faegi/mapserver that referenced this pull request Apr 9, 2013
@mkofahl @tbonfort mkofahl + tbonfort Correct wgs84 bbox in WFS GetCapabilties (#4499) 9509269
@tbonfort tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Apr 13, 2013
@tbonfort tbonfort correct expected result c44f025
@tbonfort tbonfort added a commit that referenced this pull request Apr 13, 2013
@tbonfort tbonfort update submodule after #4633 and #4499 92a033b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment