New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct wgs84 bbox in WFS GetCapabilties #4499

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mkofahl
Contributor

mkofahl commented Oct 18, 2012

For layers having another source datum than wgs84 the wgs84 bbox is currently wrong in the WFS getcapabilties document. Compared to the WMS server code, the datum wasn't set in msProjectRect(). fixes #4498

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Oct 18, 2012

Member

@mkofahl can you check that the failing tests are what's expected and that they can be updated? There seems to be an issue with some of them, the bounding rect having changed from a box to a point.

Member

tbonfort commented Oct 18, 2012

@mkofahl can you check that the failing tests are what's expected and that they can be updated? There seems to be an issue with some of them, the bounding rect having changed from a box to a point.

mkofahl pushed a commit to faegi/mapserver that referenced this pull request Oct 20, 2012

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl Oct 20, 2012

Contributor

@tbonfort In some cases coordinates were projected to wgs84 twice. Fixed. The new ows:WGS84BoundingBox for layer multi in msautotest/wxs/expected/wfsogr11_caps.xml looks fine and is in line with the bbox generated from the wms code using that layer definition.

Contributor

mkofahl commented Oct 20, 2012

@tbonfort In some cases coordinates were projected to wgs84 twice. Fixed. The new ows:WGS84BoundingBox for layer multi in msautotest/wxs/expected/wfsogr11_caps.xml looks fine and is in line with the bbox generated from the wms code using that layer definition.

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Dec 14, 2012

Member

@mapserver-bot retest this please

Member

tbonfort commented Dec 14, 2012

@mapserver-bot retest this please

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Dec 14, 2012

Member

@mkofahl there's still a failing test (c.f. http://ci.mapserver.org/job/mapserverpullrequests/66/console at the end of the page for the diff). Can you check wether the test needs updating or wether it's an issue with the patch ? Also, should this go to master or 6.2 ?

Member

tbonfort commented Dec 14, 2012

@mkofahl there's still a failing test (c.f. http://ci.mapserver.org/job/mapserverpullrequests/66/console at the end of the page for the diff). Can you check wether the test needs updating or wether it's an issue with the patch ? Also, should this go to master or 6.2 ?

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl Dec 14, 2012

Contributor

@tbonfort Test results needs to be updated. But doing the transformation with ogr2ogr I do get coordinates which neither goes with those in the expected results nor with this patch. Will try to get the reason for it soon.

Contributor

mkofahl commented Dec 14, 2012

@tbonfort Test results needs to be updated. But doing the transformation with ogr2ogr I do get coordinates which neither goes with those in the expected results nor with this patch. Will try to get the reason for it soon.

mkofahl pushed a commit to faegi/mapserver that referenced this pull request Dec 19, 2012

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl Mar 22, 2013

Contributor

msautotest corrected at mapserver/msautotest_DEPRECATED#15

Contributor

mkofahl commented Mar 22, 2013

msautotest corrected at mapserver/msautotest_DEPRECATED#15

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl Mar 22, 2013

Contributor

@tbonfort Are you ok with msOWSProjectToWGS84 having hard coded proj4 parameters?

Contributor

mkofahl commented Mar 22, 2013

@tbonfort Are you ok with msOWSProjectToWGS84 having hard coded proj4 parameters?

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Mar 22, 2013

Member

@mkofahl I have no idea of what the implications would be. Maybe @dmorissette can comment ?

Member

tbonfort commented Mar 22, 2013

@mkofahl I have no idea of what the implications would be. Maybe @dmorissette can comment ?

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Mar 29, 2013

Member

rebased and applied in 23f61d0

Member

tbonfort commented Mar 29, 2013

rebased and applied in 23f61d0

@tbonfort tbonfort closed this Mar 29, 2013

mkofahl added a commit to faegi/mapserver that referenced this pull request Apr 9, 2013

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Apr 13, 2013

tbonfort added a commit that referenced this pull request Apr 13, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment