Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly detect presence of __sync_fetch_and_add #4502

Merged
merged 1 commit into from
Oct 25, 2012

Conversation

unicolet
Copy link
Contributor

It seems that gcc will provide a stub function on architectures that don't support atomic operations like __sync_fetch_and_add unless the argument is not an int32 and its return value is not used. This breaks mapserver compilation because prior to this pr the detection code did not check for the same exact conditions under which __sync_fetch_and_add is used in mapserver internals.

This pr improves the detection code so that situations like those described above can be handled correctly.

@tbonfort
Copy link
Member

@unicolet is this good for 6.2.0 ?

@unicolet
Copy link
Contributor Author

I think so, I was waiting for confirmation by the users on the ML

On Fri, Oct 19, 2012 at 3:07 PM, Thomas Bonfort notifications@github.comwrote:

@unicolet https://github.com/unicolet is this good for 6.2.0 ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4502#issuecomment-9600263.

@AndreHeinecke
Copy link

I found this patch through google after getting the build error fixed by this.

I successful used (and needed) this patch to compile mapserver 6.2.0-rc1on an x86 centos 5 system.
Thanks.

@unicolet
Copy link
Contributor Author

Andre, thanks for your feedback.
We will merge the pull request asap.

Regards,
Umberto

On Thursday, October 25, 2012, Andre Heinecke wrote:

I found this patch through google after getting the build error fixed by
this.

I successful used (and needed) this patch to compile mapserver 6.2.0-rc1on
an x86 centos 5 system.
Thanks.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4502#issuecomment-9783169.

unicolet added a commit that referenced this pull request Oct 25, 2012
correctly detect presence of __sync_fetch_and_add
@unicolet unicolet merged commit 3471778 into MapServer:master Oct 25, 2012
mkofahl pushed a commit to faegi/mapserver that referenced this pull request Apr 9, 2013
correctly detect presence of __sync_fetch_and_add
@ghost ghost assigned unicolet Apr 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants