correctly detect presence of __sync_fetch_and_add #4502
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that gcc will provide a stub function on architectures that don't support atomic operations like __sync_fetch_and_add unless the argument is not an int32 and its return value is not used. This breaks mapserver compilation because prior to this pr the detection code did not check for the same exact conditions under which __sync_fetch_and_add is used in mapserver internals.
This pr improves the detection code so that situations like those described above can be handled correctly.