New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant call to `msDebugInitFromEnv()` in `mapserv` #4522

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@homme
Contributor

homme commented Nov 12, 2012

msSetup() already calls msDebugInitFromEnv().

Remove redundant call to `msDebugInitFromEnv()`
`msSetup()` already calls `msDebugInitFromEnv()`.
@mapserver-bot

This comment has been minimized.

Show comment
Hide comment
@mapserver-bot

mapserver-bot Nov 12, 2012

Can one of the admins verify this patch?

mapserver-bot commented Nov 12, 2012

Can one of the admins verify this patch?

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort
Member

tbonfort commented Nov 12, 2012

@mapserver-bot ok to test

Specify correct "C" linkage in `cgiutil.h`
`cgiutil.h` is the only file included by `mapserver.h` which defines
symbols and which isn't wrapped by `extern "C"`: its symbols end up in
`libmapserver` and without this fix linking against them in C++ fails.
@homme

This comment has been minimized.

Show comment
Hide comment
@homme

homme Nov 12, 2012

Contributor

I was going to action a separate pull request for the cgiutil.h change but it seems to have been automatically included here!
edit: just realised this is because I didn't read the following:

You can add more commits to this pull request by pushing to the master branch on homme/mapserver

Contributor

homme commented Nov 12, 2012

I was going to action a separate pull request for the cgiutil.h change but it seems to have been automatically included here!
edit: just realised this is because I didn't read the following:

You can add more commits to this pull request by pushing to the master branch on homme/mapserver

@dmorissette

This comment has been minimized.

Show comment
Hide comment
@dmorissette

dmorissette Nov 12, 2012

Contributor

Note that the comment above the call to msInitDebugFromFile() that you replaced in your patch needs to be either edited or removed since it loses its meaning with this change:

/* Use MS_ERRORFILE and MS_DEBUGLEVEL env vars if set */
Contributor

dmorissette commented Nov 12, 2012

Note that the comment above the call to msInitDebugFromFile() that you replaced in your patch needs to be either edited or removed since it loses its meaning with this change:

/* Use MS_ERRORFILE and MS_DEBUGLEVEL env vars if set */

@ghost ghost assigned tbonfort Nov 14, 2012

@tbonfort tbonfort closed this in 5e3bc56 Dec 11, 2012

mkofahl pushed a commit to faegi/mapserver that referenced this pull request Apr 9, 2013

Remove redundant call to msDebugInitFromEnv (#4522)
`msSetup()` already calls `msDebugInitFromEnv()`.

Specify correct "C" linkage in `cgiutil.h`

`cgiutil.h` is the only file included by `mapserver.h` which defines
symbols and which isn't wrapped by `extern "C"`: its symbols end up in
`libmapserver` and without this fix linking against them in C++ fails.

closes #4522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment