New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thread safety issue in `msLoadMapFromString()` #4523

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@homme
Contributor

homme commented Nov 13, 2012

The TLOCK_PARSER thread mutex is now released after the call to msyylex_destroy() which otherwise clobbers global lexer variables that may be in use in another thread.

Fix thread safety issue in `msLoadMapFromString()`
The `TLOCK_PARSER` thread mutex is now released after the call to
`msyylex_destroy()` which otherwise clobbers global lexer variables
that may be in use in another thread.
@unicolet

This comment has been minimized.

Show comment
Hide comment
@unicolet

unicolet Nov 14, 2012

Contributor

looks good to merge to me

Contributor

unicolet commented Nov 14, 2012

looks good to merge to me

@ghost ghost assigned tbonfort Nov 14, 2012

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime Nov 16, 2012

Member

I'm curious how to merge this into branch-6-2 and master easily... Watching. Steve

Member

sdlime commented Nov 16, 2012

I'm curious how to merge this into branch-6-2 and master easily... Watching. Steve

@tbonfort tbonfort closed this in e9e4894 Dec 11, 2012

mkofahl pushed a commit to faegi/mapserver that referenced this pull request Apr 9, 2013

Fix thread safety issue in msLoadMapFromString (mapserver#4523)
The `TLOCK_PARSER` thread mutex is now released after the call to
`msyylex_destroy()` which otherwise clobbers global lexer variables
that may be in use in another thread.

closes mapserver#4523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment