A big offset on polygon can show weird results #4554

Merged
merged 1 commit into from Aug 23, 2013

Projects

None yet

2 participants

@yjacolin
Contributor

See screenshot (top and left border) using this STYLE:

    STYLE
        COLOR 100 0 0
        OUTLINECOLOR 0 0 80
            WIDTH 5
    END
      STYLE
         SYMBOL 'point_bleu'
         COLOR 200 10 10
         OUTLINECOLOR 10 10 200
         OFFSET 15 15
         SIZE 5.0
      END

but_polygone_en_ligne_with_offset

@tbonfort
Member

not a bug. if you offset diagonally to the bottom right (offset 15 15) then diagonal lines going from top left to bottom right "seem" as if they haven't moved.

@tbonfort tbonfort closed this Dec 28, 2012
@yjacolin
Contributor

Thomas,

The problem is that those horizontal and verticla lines exist only for drawing picture: polygon have not this shape (french departement).

Y.

@tbonfort
Member

ha, ok! I hadn't noticed those :)
definitely a bug then

@tbonfort tbonfort reopened this Dec 28, 2012
@tbonfort tbonfort was assigned Aug 20, 2013
@tbonfort tbonfort expand clipping rectangle to account for offset (#4554)
also adresses cleaner defines for single-sided offsets from #4716
d231a75
@tbonfort tbonfort merged commit d231a75 into mapserver:master Aug 23, 2013

1 check passed

default The Travis CI build passed
Details
@tbonfort
Member

@yjacolin can you test this fix please?

@yjacolin
Contributor

@tbonfort how can I be sure that the mapserv cgi used is the one from you repository? As I have previous build and still the issue exists, I would like to be sure that I am not wrong somewhere. I removed old build with make uninstall then cmake . && make && sudo make install.

Fribidi support should be enough to tell me that I am using your repository as I have never build my previous test with this libraryn, only with your repository :

/usr/local/bin/mapserv -v
MapServer version 6.3-dev OUTPUT=PNG OUTPUT=JPEG SUPPORTS=PROJ SUPPORTS=AGG SUPPORTS=FREETYPE SUPPORTS=CAIRO SUPPORTS=ICONV SUPPORTS=FRIBIDI SUPPORTS=WMS_SERVER SUPPORTS=WFS_SERVER SUPPORTS=WCS_SERVER SUPPORTS=FASTCGI SUPPORTS=GEOS INPUT=JPEG INPUT=POSTGIS INPUT=OGR INPUT=GDAL INPUT=SHAPEFILE

I have now a working project, if you need it for testing.

Y.

@yjacolin
Contributor

@tbonfort forget my previous comment, I am still using your master branch instead of the branch :(

@yjacolin
Contributor

tested with the correct branch:)

MapServer version 6.4.0-beta2 OUTPUT=PNG OUTPUT=JPEG SUPPORTS=PROJ SUPPORTS=AGG SUPPORTS=FREETYPE SUPPORTS=CAIRO SUPPORTS=ICONV SUPPORTS=FRIBIDI SUPPORTS=WMS_SERVER SUPPORTS=WFS_SERVER SUPPORTS=WCS_SERVER SUPPORTS=FASTCGI SUPPORTS=GEOS INPUT=JPEG INPUT=POSTGIS INPUT=OGR INPUT=GDAL INPUT=SHAPEFILE

and working as expected, thanks!

Y.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment