New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse key value pairs sent in POST body #4627

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@mkofahl
Contributor

mkofahl commented Apr 9, 2013

MapServer lacks support of reading KVP from a POST body. This got lost somewhere between 5.4 and 6.2.
I would prefer adding a new request method, e.g. MS_POSTKVP_REQUEST in order to avoid string comparison. Any opinions?

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl
Contributor

mkofahl commented Apr 9, 2013

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 9, 2013

Member

@mkofahl can you either rebase this one or open a new PR with the rebased commits only? thanks

Member

tbonfort commented Apr 9, 2013

@mkofahl can you either rebase this one or open a new PR with the rebased commits only? thanks

mkofahl added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Apr 10, 2013

@tbonfort tbonfort closed this Apr 10, 2013

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 10, 2013

Member

rebased/squashed to master in 572aa67

Member

tbonfort commented Apr 10, 2013

rebased/squashed to master in 572aa67

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl Apr 10, 2013

Contributor

Should go in 6-2, too,

Contributor

mkofahl commented Apr 10, 2013

Should go in 6-2, too,

@mkofahl mkofahl reopened this Apr 10, 2013

mkofahl added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Apr 11, 2013

mkofahl added a commit that referenced this pull request Apr 11, 2013

Parse key value pairs sent in POST body (#4627)
Backported from the master branch.

Conflicts:
	msautotest
@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 11, 2013

Member

backported to 6.2 in 307376c

Member

tbonfort commented Apr 11, 2013

backported to 6.2 in 307376c

@constantinius

This comment has been minimized.

Show comment
Hide comment
@constantinius

constantinius May 7, 2013

Contributor

This segfaults when request->contenttype is set to NULL. I openend an issue (#4650)

Contributor

constantinius commented May 7, 2013

This segfaults when request->contenttype is set to NULL. I openend an issue (#4650)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment