New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder to fix EPSG parsing code to make it thread safe #4731

Closed
wants to merge 4 commits into
base: branch-7-0
from

Conversation

Projects
None yet
3 participants
@tbonfort
Member

tbonfort commented Nov 10, 2015

While adding Java mapscript to the test target I have received a segfault
in the WxS threaded tests that come with Java mapscript.

In an attempt to fix it I have, for now, blocked concurrent access to msWMSGetCapabilities, but this is probably too coarse.

The original pull request with discussion is here:
#4728

This ticket is a reminder to fix the EPSG parsing code, with a hint that the cause of the segfaults could be the use of the static variable epsgCode mentioned here:

http://lists.osgeo.org/pipermail/mapserver-dev/2013-August/013509.html

Once the EPSG parsing code has been fixed the locks around msWMSGetCapabilities must be removed.

unicolet added a commit that referenced this pull request Aug 14, 2013

Merge pull request #4728 from unicolet/java-autotest-wxs-thread-safety
Add Java mapscript to the test target; Fix a thread safety issue with msWMSGetCapabilities by wrapping it with a lock.
Should be improved by tackling #4731
@jratike80

This comment has been minimized.

jratike80 commented Nov 10, 2015

I wonder if the EPSG parsing code has been fixed by now.

@unicolet

This comment has been minimized.

Contributor

unicolet commented Nov 10, 2015

@jratike80 thanks for the housekeeping ;-)
I'll check again asap and then update this ticket.

@tbonfort

This comment has been minimized.

Member

tbonfort commented Nov 10, 2015

The original code is still there. I'll implement the suggested fix

@tbonfort tbonfort self-assigned this Nov 10, 2015

tbonfort added some commits Nov 10, 2015

fix
@tbonfort

This comment has been minimized.

Member

tbonfort commented Nov 10, 2015

note to future @tbonfort: never take on a fix on the OWS code, how ever trivial it may seem at first, that code is brutal...
The attached patches apply to branch-7-0 given it's a bugfix, however considering their extent they may be better suited for the master branch. Any comments about that @sdlime or @dmorissette ?

@tbonfort tbonfort added this to the 7.2 Release milestone Feb 24, 2016

tbonfort added a commit that referenced this pull request Feb 24, 2016

@tbonfort

This comment has been minimized.

Member

tbonfort commented Feb 24, 2016

applied to master in 4dd30cd, this will be in 7.2

@tbonfort tbonfort closed this Feb 24, 2016

@tbonfort tbonfort deleted the tbonfort:issues/4731-thread-safe-epsg-parsing branch Feb 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment