Use ${LIB_INSTALL_DIR} to install libs in the right path on 64 bit syste... #4789

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@buildrz
buildrz commented Oct 11, 2013

Libraries are harcoded to install in lib but on 64 bit systems they should be installed in lib64.
Use ${LIB_INSTALL_DIR} provided by Cmake to install libs in the right path.

@tbonfort
Member

@QuelleVille I'm not sure the buildbot emailed you, but your patch breaks the build. Can you please reply wether or not you received an email notification about the failed build, thanks.

@buildrz
buildrz commented Oct 11, 2013

Sorry, i did not :-/

@buildrz
buildrz commented Oct 11, 2013

Hum, looks like it's a Fedora/RHEL mod to cmake. I'll further look into it.

@buildrz
buildrz commented Oct 11, 2013

That might fix it but I can't test. Let's see with next Travis run.

@buildrz
buildrz commented Oct 11, 2013

@tbonfort : I'm not familiar with Travis. It's still breaking the build, shall I close this pull request ?

@tbonfort
Member

no, you can leave it open. travis is just telling us that we shouldn't blindly apply your patch as it would break the build.

@tbonfort
Member

lloyd/yajl@402d4a3 might be helpful. I don't think there's an automatic way to set the destination to lib64 rather than lib, but I agree it should be overridable through command line options (FWIW I believe the suse/centos maintainers patch the cmakefile to hardcode lib64)

@tbonfort tbonfort added a commit to tbonfort/mapserver that referenced this pull request Oct 13, 2013
@tbonfort tbonfort try fixing lib install directory (#4789) c433652
@tbonfort tbonfort added a commit to tbonfort/mapserver that referenced this pull request Oct 15, 2013
@tbonfort tbonfort use lib64 instead of lib on select linux systems (#4789) 6af2189
@tbonfort
Member

fixed with #4791

@tbonfort tbonfort closed this Oct 16, 2013
@tbonfort tbonfort added a commit that referenced this pull request Oct 17, 2013
@tbonfort tbonfort fixups for master of #4789 f3d8234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment