New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ${LIB_INSTALL_DIR} to install libs in the right path on 64 bit syste... #4789

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ghost

ghost commented Oct 11, 2013

Libraries are harcoded to install in lib but on 64 bit systems they should be installed in lib64.
Use ${LIB_INSTALL_DIR} provided by Cmake to install libs in the right path.

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Oct 11, 2013

Member

@QuelleVille I'm not sure the buildbot emailed you, but your patch breaks the build. Can you please reply wether or not you received an email notification about the failed build, thanks.

Member

tbonfort commented Oct 11, 2013

@QuelleVille I'm not sure the buildbot emailed you, but your patch breaks the build. Can you please reply wether or not you received an email notification about the failed build, thanks.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 11, 2013

Sorry, i did not :-/

ghost commented Oct 11, 2013

Sorry, i did not :-/

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 11, 2013

Hum, looks like it's a Fedora/RHEL mod to cmake. I'll further look into it.

ghost commented Oct 11, 2013

Hum, looks like it's a Fedora/RHEL mod to cmake. I'll further look into it.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 11, 2013

That might fix it but I can't test. Let's see with next Travis run.

ghost commented Oct 11, 2013

That might fix it but I can't test. Let's see with next Travis run.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 11, 2013

@tbonfort : I'm not familiar with Travis. It's still breaking the build, shall I close this pull request ?

ghost commented Oct 11, 2013

@tbonfort : I'm not familiar with Travis. It's still breaking the build, shall I close this pull request ?

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Oct 11, 2013

Member

no, you can leave it open. travis is just telling us that we shouldn't blindly apply your patch as it would break the build.

Member

tbonfort commented Oct 11, 2013

no, you can leave it open. travis is just telling us that we shouldn't blindly apply your patch as it would break the build.

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Oct 11, 2013

Member

lloyd/yajl@402d4a3 might be helpful. I don't think there's an automatic way to set the destination to lib64 rather than lib, but I agree it should be overridable through command line options (FWIW I believe the suse/centos maintainers patch the cmakefile to hardcode lib64)

Member

tbonfort commented Oct 11, 2013

lloyd/yajl@402d4a3 might be helpful. I don't think there's an automatic way to set the destination to lib64 rather than lib, but I agree it should be overridable through command line options (FWIW I believe the suse/centos maintainers patch the cmakefile to hardcode lib64)

tbonfort added a commit to tbonfort/mapserver that referenced this pull request Oct 13, 2013

tbonfort added a commit to tbonfort/mapserver that referenced this pull request Oct 15, 2013

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Oct 16, 2013

Member

fixed with #4791

Member

tbonfort commented Oct 16, 2013

fixed with #4791

@tbonfort tbonfort closed this Oct 16, 2013

tbonfort added a commit that referenced this pull request Oct 17, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment