RFC109: Refactor Runtime Substitution Methods #4877

Merged
merged 1 commit into from Mar 7, 2014

Conversation

Projects
None yet
1 participant
@tbonfort
Member

tbonfort commented Mar 3, 2014

  • Rewrite substitution loops to first check for available VALIDATION
    patterns before looping through KVP pairs. This is possible because
    VALIDATIONs are mandatory, and speeds things up substantially in the
    general case when there are few/no substitutions to apply
  • Allow runtime substitutions to apply to map->metadata,
    layer->metadata, and all outputformat->formatoptions

@tbonfort tbonfort added this to the 7.0 Release milestone Mar 3, 2014

@tbonfort tbonfort self-assigned this Mar 3, 2014

tbonfort added a commit to tbonfort/mapserver that referenced this pull request Mar 3, 2014

RFC109: Refactor Application of Runtime Substitutions (#4877)
- Rewrite substitution loops to first check for available VALIDATION
  patterns before looping through KVP pairs. This is possible because
  VALIDATIONs are mandatory, and speeds things up substantially in the
  general case when there are few/no substitutions to apply

- Allow runtime substitutions to apply to map->metadata,
  layer->metadata, and all outputformat->formatoptions

tbonfort added a commit to mapserver/docs that referenced this pull request Mar 3, 2014

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Mar 7, 2014

RFC109: Refactor Application of Runtime Substitutions (#4877)
- Rewrite substitution loops to first check for available VALIDATION
  patterns before looping through KVP pairs. This is possible because
  VALIDATIONs are mandatory, and speeds things up substantially in the
  general case when there are few/no substitutions to apply

- Allow runtime substitutions to apply to map->metadata,
  layer->metadata, and all outputformat->formatoptions

@tbonfort tbonfort merged commit c4542bc into mapserver:master Mar 7, 2014

1 check passed

default The Travis CI build passed
Details

tbonfort added a commit to mapserver/docs that referenced this pull request Mar 7, 2014

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Mar 8, 2014

tbonfort added a commit that referenced this pull request Mar 8, 2014

zidge added a commit to mapsherpa/mapserver that referenced this pull request Mar 10, 2014

RFC109: Refactor Application of Runtime Substitutions (#4877)
- Rewrite substitution loops to first check for available VALIDATION
  patterns before looping through KVP pairs. This is possible because
  VALIDATIONs are mandatory, and speeds things up substantially in the
  general case when there are few/no substitutions to apply

- Allow runtime substitutions to apply to map->metadata,
  layer->metadata, and all outputformat->formatoptions

zidge added a commit to mapsherpa/mapserver that referenced this pull request Mar 10, 2014

zidge added a commit to mapsherpa/mapserver that referenced this pull request Mar 10, 2014

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Mar 11, 2014

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Mar 11, 2014

tbonfort added a commit that referenced this pull request Mar 11, 2014

avoid numerous error messages for failed runtime substitutions (#4877)
don't print error messages in regex/validation checks, the higher level
callers already print one out. also add back debugging messages in the
debug logs.

tbonfort added a commit to tbonfort/mapserver that referenced this pull request Feb 11, 2015

tbonfort added a commit to tbonfort/msautotest that referenced this pull request Feb 11, 2015

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Feb 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment