New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Validation of SLD ExternalGraphic OnlineResource #4883

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@luipir
Contributor

luipir commented Mar 15, 2014

Onlineresource must validate against "sld_external_graphic" entry of
map->web->validation in order to be taken into account.

added thanks to Regione Toscana - SITA

added managing of SVG format in applytSLD - added thanks to Regione T…
…oscana - SITA

Added support to svg managing creation of SYMBOL for each svg symbol and setting MS_SYMBOL_SVG.
Skipping remote symbols in case not set ALLOW_REMOTE_ASSETS config option.
@luipir

This comment has been minimized.

Show comment
Hide comment
@luipir

luipir Mar 15, 2014

Contributor

old discussion was in:
#4842

Contributor

luipir commented Mar 15, 2014

old discussion was in:
#4842

@luipir

This comment has been minimized.

Show comment
Hide comment
@luipir

luipir Mar 15, 2014

Contributor

Travis fail wxs => wms_get_map_symbol_ext_sld.png but it should fail because this patch avoid loading external svg if otion is not set.

I can't reproduce test locally... If I do I've 239 test fail! so probably I've to set-up test env. Let me know If I can help to set-up test for this patch

Contributor

luipir commented Mar 15, 2014

Travis fail wxs => wms_get_map_symbol_ext_sld.png but it should fail because this patch avoid loading external svg if otion is not set.

I can't reproduce test locally... If I do I've 239 test fail! so probably I've to set-up test env. Let me know If I can help to set-up test for this patch

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Mar 25, 2014

tbonfort added a commit that referenced this pull request Mar 25, 2014

Require Validation of SLD ExternalGraphic OnlineResource (#4883)
Onlineresource must validate against "sld_external_graphic" entry of
map->web->validation in order to be taken into account.

added thanks to Regione Toscana - SITA

tbonfort added a commit to mapserver/docs that referenced this pull request Mar 25, 2014

@luipir

This comment has been minimized.

Show comment
Hide comment
@luipir

luipir Mar 25, 2014

Contributor

compared to the original pull request "http" contro (bb0a72f) l has been removed using control in map->web->validation as VALIDATION regexp (e184249)
without VALIDATION no external graphic will be possible
with VALIDATION block setting sld_external_graphic "" it's possibile to add external symbol that match pattern

Contributor

luipir commented Mar 25, 2014

compared to the original pull request "http" contro (bb0a72f) l has been removed using control in map->web->validation as VALIDATION regexp (e184249)
without VALIDATION no external graphic will be possible
with VALIDATION block setting sld_external_graphic "" it's possibile to add external symbol that match pattern

@luipir

This comment has been minimized.

Show comment
Hide comment
@luipir

luipir Mar 25, 2014

Contributor

pull request will be closed because modification has been done directly on master during VIenna OSGeo CodeSprint

Contributor

luipir commented Mar 25, 2014

pull request will be closed because modification has been done directly on master during VIenna OSGeo CodeSprint

@luipir luipir changed the title from Added managing of SVG format in applytSLD - added thanks to Regione Toscana SITA to Require Validation of SLD ExternalGraphic OnlineResource Mar 25, 2014

@luipir luipir closed this Mar 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment