Add <ogc:PropertyName></ogc:PropertyName> tags in <label></label> #4921

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@yjacolin
Contributor

yjacolin commented May 7, 2014

Add ogc:PropertyName/ogc:PropertyName tags in when we are using values from column (ie property in OGC terms). In MapServer this is the only way to get value for label via labelitem parameter.

Add <ogc:PropertyName></ogc:PropertyName> tags in <label></label> whe…
…n we are using values from column (ie property in OGC terms). In MapServer this is the only way to get value for label via labelitem parameter
@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Sep 2, 2014

Member

Is this needed? From the SLD spec I understood that <label>column_name</label> is valid, no?

Member

tbonfort commented Sep 2, 2014

Is this needed? From the SLD spec I understood that <label>column_name</label> is valid, no?

@yjacolin

This comment has been minimized.

Show comment
Hide comment
@yjacolin

yjacolin Sep 2, 2014

Contributor

@tbonfort

  1. OGC standard showed only example with PropertyName.
  2. GeoServer will show the content of the label tag if no PropertyName is used, in you example GeoServer will display "column_name" on the map, not the value of column_name field for the feature. GeoServer need PropertyName to link the value to an attribut field.

In the case of MapServer, we can't use a defaut string for the label in the MapFile with LABELITEM, only an attribut table.

Does it make sense for you?

Contributor

yjacolin commented Sep 2, 2014

@tbonfort

  1. OGC standard showed only example with PropertyName.
  2. GeoServer will show the content of the label tag if no PropertyName is used, in you example GeoServer will display "column_name" on the map, not the value of column_name field for the feature. GeoServer need PropertyName to link the value to an attribut field.

In the case of MapServer, we can't use a defaut string for the label in the MapFile with LABELITEM, only an attribut table.

Does it make sense for you?

tbonfort added a commit that referenced this pull request Sep 2, 2014

Add <ogc:PropertyName></ogc:PropertyName> tags in SLD label (#4921)
Added in <label></label> when we are using values from an attribute
(ie property in OGC terms). In MapServer this is the only way to get
a value for a label when using the labelitem parameter.
@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Sep 2, 2014

Member

applied in d2867f7

Member

tbonfort commented Sep 2, 2014

applied in d2867f7

@tbonfort tbonfort closed this Sep 2, 2014

@yjacolin yjacolin deleted the yjacolin:sld_label_property branch Sep 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment