Fix rfc91 ogr #4999

Merged
merged 5 commits into from Sep 20, 2014

Conversation

Projects
None yet
2 participants
@rouault
Contributor

rouault commented Sep 20, 2014

No description provided.

tbonfort and others added some commits Sep 19, 2014

FLTGetSpatialComparisonCommonExpression(): use polygon instead of rec…
…tangle (#4974)

* Reprojection of BBOX to layer SRS should be done as a rectangle to avoid capturing
too many features. Improves wfsogr10_twolayer.xml
* Also add a hack from -180,-90,180,90 BBOX when reprojecting to a projected SRS.

@rouault rouault merged commit 6a4d00e into mapserver:master Sep 20, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details
@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Jul 20, 2015

@rouault @sdlime : This function was added for this commit, however I see that it is not being used in the current 7.0 branch. Can you have a look as to wether there was an error during a merge, or if we should now remove it alltogether. thanks, thomas

@rouault @sdlime : This function was added for this commit, however I see that it is not being used in the current 7.0 branch. Can you have a look as to wether there was an error during a merge, or if we should now remove it alltogether. thanks, thomas

This comment has been minimized.

Show comment
Hide comment
@rouault

rouault Jul 20, 2015

Owner

Looking at history of mapogr.cpp, the call to msOGRTranslateMsExpressionToOGRSQL() was removed by @sdline in a large refactoring in 0a48731 . So the function can be removed now. But with this removal, I'm wondering if MapServer filters (e.g. a WFS Filter) can now be translated to OGR SQL for the compatible subset.

Owner

rouault replied Jul 20, 2015

Looking at history of mapogr.cpp, the call to msOGRTranslateMsExpressionToOGRSQL() was removed by @sdline in a large refactoring in 0a48731 . So the function can be removed now. But with this removal, I'm wondering if MapServer filters (e.g. a WFS Filter) can now be translated to OGR SQL for the compatible subset.

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Jul 20, 2015

I've added an autotest in mapserver/msautotest_DEPRECATED@51d6652 to check for WFS filters using OGR backends, and the results are identical to the direct shapefile access which would tend to show that the filtering is working correctly. However @sdlime could you check that all is OK inside the OGR driver concerning the RFC91 filtering?

I've added an autotest in mapserver/msautotest_DEPRECATED@51d6652 to check for WFS filters using OGR backends, and the results are identical to the direct shapefile access which would tend to show that the filtering is working correctly. However @sdlime could you check that all is OK inside the OGR driver concerning the RFC91 filtering?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment