New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RFC-113 Layer Compositing Framework #5071

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants

@tbonfort tbonfort changed the title from Implement RFC-113 Layer Compositing Framework (#5067) to Implement RFC-113 Layer Compositing Framework Feb 12, 2015

tbonfort added a commit to mapserver/msautotest_DEPRECATED that referenced this pull request Feb 12, 2015

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 12, 2015

Member

merged into master in 29db335

Member

tbonfort commented Feb 12, 2015

merged into master in 29db335

@tbonfort tbonfort closed this Feb 12, 2015

@rouault

This comment has been minimized.

Show comment
Hide comment
@rouault

rouault Feb 12, 2015

Contributor

What is the minimum cairo version required ?
I get build failures with the ancient cairo 1.8.10-2ubuntu1 of my ancient Ubuntu 10.04:

/home/even/mapserver/git/mapserver/mapcairo.c:809: error: (Each undeclared identifier is reported only once
/home/even/mapserver/git/mapserver/mapcairo.c:809: error: for each function it appears in.)
/home/even/mapserver/git/mapserver/mapcairo.c:811: error: ‘CAIRO_OPERATOR_SCREEN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:813: error: ‘CAIRO_OPERATOR_OVERLAY’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:815: error: ‘CAIRO_OPERATOR_DARKEN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:817: error: ‘CAIRO_OPERATOR_LIGHTEN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:819: error: ‘CAIRO_OPERATOR_COLOR_DODGE’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:821: error: ‘CAIRO_OPERATOR_COLOR_BURN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:823: error: ‘CAIRO_OPERATOR_HARD_LIGHT’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:825: error: ‘CAIRO_OPERATOR_SOFT_LIGHT’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:827: error: ‘CAIRO_OPERATOR_DIFFERENCE’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:829: error: ‘CAIRO_OPERATOR_EXCLUSION’ undeclared (first use in this function)
/

Contributor

rouault commented Feb 12, 2015

What is the minimum cairo version required ?
I get build failures with the ancient cairo 1.8.10-2ubuntu1 of my ancient Ubuntu 10.04:

/home/even/mapserver/git/mapserver/mapcairo.c:809: error: (Each undeclared identifier is reported only once
/home/even/mapserver/git/mapserver/mapcairo.c:809: error: for each function it appears in.)
/home/even/mapserver/git/mapserver/mapcairo.c:811: error: ‘CAIRO_OPERATOR_SCREEN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:813: error: ‘CAIRO_OPERATOR_OVERLAY’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:815: error: ‘CAIRO_OPERATOR_DARKEN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:817: error: ‘CAIRO_OPERATOR_LIGHTEN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:819: error: ‘CAIRO_OPERATOR_COLOR_DODGE’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:821: error: ‘CAIRO_OPERATOR_COLOR_BURN’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:823: error: ‘CAIRO_OPERATOR_HARD_LIGHT’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:825: error: ‘CAIRO_OPERATOR_SOFT_LIGHT’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:827: error: ‘CAIRO_OPERATOR_DIFFERENCE’ undeclared (first use in this function)
/home/even/mapserver/git/mapserver/mapcairo.c:829: error: ‘CAIRO_OPERATOR_EXCLUSION’ undeclared (first use in this function)
/

@rouault

This comment has been minimized.

Show comment
Hide comment
@rouault

rouault Feb 12, 2015

Contributor

Answer to myself: it seems that cairo 1.10 is required

Contributor

rouault commented Feb 12, 2015

Answer to myself: it seems that cairo 1.10 is required

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 12, 2015

Member

I think they were renamed. I'll have a look and commit an #ifdef'd block if that's possible.

Member

tbonfort commented Feb 12, 2015

I think they were renamed. I'll have a look and commit an #ifdef'd block if that's possible.

@rouault

This comment has been minimized.

Show comment
Hide comment
@rouault

rouault Feb 12, 2015

Contributor

There are also a few warnings possibly related with that dev :

Extract:

/home/even/mapserver/git/mapserver/mapcontext.c: In function ‘msLoadMapContextLayer’:
/home/even/mapserver/git/mapserver/mapcontext.c:1037: warning: implicit declaration of function ‘initLayerCompositer’

[ 26%] Building C object CMakeFiles/mapserver.dir/mapcopy.c.o
/home/even/mapserver/git/mapserver/mapcopy.c: In function ‘msCopyLabel’:
/home/even/mapserver/git/mapserver/mapcopy.c:403: warning: implicit declaration of function ‘initLeader’
/home/even/mapserver/git/mapserver/mapcopy.c: In function ‘msCopyLayer’:
/home/even/mapserver/git/mapserver/mapcopy.c:1115: warning: implicit declaration of function ‘freeGrid’

Building C object CMakeFiles/mapserver.dir/maputil.c.o
/home/even/mapserver/git/mapserver/maputil.c: In function ‘msCheckParentPointer’:
/home/even/mapserver/git/mapserver/maputil.c:2164: warning: unused variable ‘fmt’
/home/even/mapserver/git/mapserver/maputil.c: In function ‘msSetLayerOpacity’:
/home/even/mapserver/git/mapserver/maputil.c:2621: warning: implicit declaration of function ‘initLayerCompositer’
/home/even/mapserver/git/mapserver/maputil.c:2624: warning: control reaches end of non-void function

[ 61%] /home/even/mapserver/git/mapserver/mapagg.cpp: In function ‘int aggCompositeRasterBuffer(imageObj*, rasterBufferObj*, CompositingOperation, int)’:
/home/even/mapserver/git/mapserver/mapagg.cpp:1321: warning: comparison between ‘enum CompositingOperation’ and ‘enum mapserver::comp_op_e’
Contributor

rouault commented Feb 12, 2015

There are also a few warnings possibly related with that dev :

Extract:

/home/even/mapserver/git/mapserver/mapcontext.c: In function ‘msLoadMapContextLayer’:
/home/even/mapserver/git/mapserver/mapcontext.c:1037: warning: implicit declaration of function ‘initLayerCompositer’

[ 26%] Building C object CMakeFiles/mapserver.dir/mapcopy.c.o
/home/even/mapserver/git/mapserver/mapcopy.c: In function ‘msCopyLabel’:
/home/even/mapserver/git/mapserver/mapcopy.c:403: warning: implicit declaration of function ‘initLeader’
/home/even/mapserver/git/mapserver/mapcopy.c: In function ‘msCopyLayer’:
/home/even/mapserver/git/mapserver/mapcopy.c:1115: warning: implicit declaration of function ‘freeGrid’

Building C object CMakeFiles/mapserver.dir/maputil.c.o
/home/even/mapserver/git/mapserver/maputil.c: In function ‘msCheckParentPointer’:
/home/even/mapserver/git/mapserver/maputil.c:2164: warning: unused variable ‘fmt’
/home/even/mapserver/git/mapserver/maputil.c: In function ‘msSetLayerOpacity’:
/home/even/mapserver/git/mapserver/maputil.c:2621: warning: implicit declaration of function ‘initLayerCompositer’
/home/even/mapserver/git/mapserver/maputil.c:2624: warning: control reaches end of non-void function

[ 61%] /home/even/mapserver/git/mapserver/mapagg.cpp: In function ‘int aggCompositeRasterBuffer(imageObj*, rasterBufferObj*, CompositingOperation, int)’:
/home/even/mapserver/git/mapserver/mapagg.cpp:1321: warning: comparison between ‘enum CompositingOperation’ and ‘enum mapserver::comp_op_e’
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment