Segfault when using ttf symbols with symbolscalednom and minsize=0 #5086

Merged
merged 1 commit into from Apr 2, 2015

Conversation

Projects
None yet
2 participants
@tbonfort
Member

tbonfort commented Apr 2, 2015

MapServer will crash at very small scales, when a ttf symbol is used together with symbolscalednom, but without minsize, which is default 0.

MAP
        SIZE 1000 500
        EXTENT -90 -90 90 90
        PROJECTION
                "init=epsg:4326"
        END

        FONTSET 'glyph.fonts'

        SYMBOL
                NAME "test"
                TYPE TRUETYPE
                FONT "arial"
                CHARACTER 'a'
        END

        LAYER
                TYPE LINE
                STATUS DEFAULT

                FEATURE
                        POINTS
                                0 0
                                20 20
                        END
                END

                NAME 'ttflayer'
                STATUS DEFAULT
                PROJECTION
                        'init=epsg:4326'
                END

                SYMBOLSCALEDENOM 100

                CLASS
                        STYLE
                                SYMBOL "test"
                                WIDTH 2
#                               MINSIZE 1
                        END
                END
        END
END

@mkofahl mkofahl added the Bug label Apr 2, 2015

@mkofahl mkofahl added this to the 7.0 Release milestone Apr 2, 2015

@tbonfort tbonfort self-assigned this Apr 2, 2015

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 2, 2015

Member

cannot reproduce ...

Member

tbonfort commented Apr 2, 2015

cannot reproduce ...

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl Apr 2, 2015

Contributor

Compiled from github master again, changed arial.ttf to Vera.ttf from msautotest, still segfaulting when running ./shp2img -m glyph.map.

Contributor

mkofahl commented Apr 2, 2015

Compiled from github master again, changed arial.ttf to Vera.ttf from msautotest, still segfaulting when running ./shp2img -m glyph.map.

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 2, 2015

Member

my bad, I was testing with 6.4. Can reproduce with 7.0-beta1

Member

tbonfort commented Apr 2, 2015

my bad, I was testing with 6.4. Can reproduce with 7.0-beta1

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Apr 2, 2015

Member

Not sure what we should be doing in this case, as we're requesting a ttf symbol that is smaller than a pixel. Should we force to size=1 or size=0 (i.e. render nothing)?

Member

tbonfort commented Apr 2, 2015

Not sure what we should be doing in this case, as we're requesting a ttf symbol that is smaller than a pixel. Should we force to size=1 or size=0 (i.e. render nothing)?

@tbonfort tbonfort merged commit 29bbefa into mapserver:branch-7-0 Apr 2, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl Apr 2, 2015

Contributor

Thank you for fixing this @tbonfort

Contributor

mkofahl commented Apr 2, 2015

Thank you for fixing this @tbonfort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment