New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A freed geometry should be set to null in msGEOSFreeGeometry() #5099

Closed
wants to merge 1 commit into
base: branch-7-0
from

Conversation

Projects
None yet
3 participants
@mkofahl
Contributor

mkofahl commented May 12, 2015

msGEOSFreeGeometry checks whether the object to be freed exists, but does not set the freed object to null. If msGEOSFreeGeometry is - accidently - called twice on the same object, Mapserver will crash.

@mkofahl mkofahl added this to the 7.0 Release milestone May 12, 2015

mkofahl added a commit to faegi/mapserver that referenced this pull request May 12, 2015

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort May 12, 2015

Member

seems good to me. Is this ready for merging ?

Member

tbonfort commented May 12, 2015

seems good to me. Is this ready for merging ?

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime May 12, 2015

Member

I would say yes...

Member

sdlime commented May 12, 2015

I would say yes...

@mkofahl

This comment has been minimized.

Show comment
Hide comment
@mkofahl

mkofahl May 12, 2015

Contributor

yes

Contributor

mkofahl commented May 12, 2015

yes

sdlime added a commit that referenced this pull request May 26, 2015

sdlime added a commit that referenced this pull request May 26, 2015

@sdlime

This comment has been minimized.

Show comment
Hide comment
@sdlime

sdlime May 26, 2015

Member

Applied in both master and branch-7-0. Thanks!

Member

sdlime commented May 26, 2015

Applied in both master and branch-7-0. Thanks!

@sdlime sdlime closed this May 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment