New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling without iconv fails. #5195

Merged
merged 1 commit into from Nov 11, 2015

Conversation

Projects
None yet
2 participants
@tbonfort
Member

tbonfort commented Nov 10, 2015

The function msLayerEncodeSahpeAttributes calls iconv_open in mapstring.c, line 2206 even if iconv is not being used. The #ifdef USE_ICONV block maybe should extend through the entire function instead of ending at line 2201 with a new ifdef USE_ICONV block starting at line 2213?

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Nov 10, 2015

Member

@offroadbis provided patch should fix the issue

Member

tbonfort commented Nov 10, 2015

@offroadbis provided patch should fix the issue

@offroadbis

This comment has been minimized.

Show comment
Hide comment
@offroadbis

offroadbis Nov 10, 2015

First time using. I am not sure that I wanted a pull request. That fixed the problem. Thanks.

offroadbis commented Nov 10, 2015

First time using. I am not sure that I wanted a pull request. That fixed the problem. Thanks.

@offroadbis offroadbis closed this Nov 10, 2015

@tbonfort tbonfort reopened this Nov 10, 2015

@tbonfort tbonfort closed this Nov 10, 2015

@tbonfort tbonfort reopened this Nov 11, 2015

@tbonfort tbonfort merged commit e47e642 into mapserver:branch-7-0 Nov 11, 2015

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment