New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels leak through MASK #5237

Merged
merged 1 commit into from Feb 11, 2016

Conversation

Projects
None yet
4 participants
@tbonfort
Member

tbonfort commented Feb 11, 2016

It seems as if there is a border problem when masking out labelled layers. Sometimes labels at the very edge of the map leak through even when they should definitely be masked away.

Example:
Input dataset:
image

The above dataset masked with a mask which is a union of the polygons at the centre of the map:
image
Geometries are correctly masked, but note the label "Nørre Broby".

Using v6.4.1

@dmorissette

This comment has been minimized.

Show comment
Hide comment
@dmorissette

dmorissette Feb 10, 2016

Contributor

Adding PROCESSING FORCE_DRAW_LABEL_CACHE=FLUSH in the last layer before the mask, or in a dummy layer with status default before the mask (to ensure that it is always on) should solve this. See #5100

Contributor

dmorissette commented Feb 10, 2016

Adding PROCESSING FORCE_DRAW_LABEL_CACHE=FLUSH in the last layer before the mask, or in a dummy layer with status default before the mask (to ensure that it is always on) should solve this. See #5100

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 10, 2016

Member

@dmorissette I think this is a bug in the masking code, not something related to labelcache flushing. reopening.

Member

tbonfort commented Feb 10, 2016

@dmorissette I think this is a bug in the masking code, not something related to labelcache flushing. reopening.

@tbonfort tbonfort reopened this Feb 10, 2016

@dmorissette

This comment has been minimized.

Show comment
Hide comment
@dmorissette

dmorissette Feb 10, 2016

Contributor

Sorry about this.

Contributor

dmorissette commented Feb 10, 2016

Sorry about this.

tbonfort added a commit to tbonfort/mapserver that referenced this pull request Feb 10, 2016

@AsgerPetersen

This comment has been minimized.

Show comment
Hide comment
@AsgerPetersen

AsgerPetersen Feb 10, 2016

No problem. I was reading through #5100 and didn't really understand the connection :-)

AsgerPetersen commented Feb 10, 2016

No problem. I was reading through #5100 and didn't really understand the connection :-)

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 10, 2016

Member

@AsgerPetersen can you apply 3eeeeed from my repo and report back ?

Member

tbonfort commented Feb 10, 2016

@AsgerPetersen can you apply 3eeeeed from my repo and report back ?

tbonfort added a commit to tbonfort/mapserver that referenced this pull request Feb 10, 2016

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 10, 2016

Member

@AsgerPetersen you'll also need b1dfd3b

Member

tbonfort commented Feb 10, 2016

@AsgerPetersen you'll also need b1dfd3b

@AsgerPetersen

This comment has been minimized.

Show comment
Hide comment
@AsgerPetersen

AsgerPetersen Feb 10, 2016

@tbonfort Thank you very much! We will give it a spin first thing tomorrow.

AsgerPetersen commented Feb 10, 2016

@tbonfort Thank you very much! We will give it a spin first thing tomorrow.

tbonfort added a commit to tbonfort/mapserver that referenced this pull request Feb 10, 2016

@Telling

This comment has been minimized.

Show comment
Hide comment
@Telling

Telling Feb 11, 2016

I've tested the additions in the issues/5237-masked-labels-bug-branch, and I can confirm that it's indeed working.

Here's a request against the released version of mapserver 7:

ixem6og4aa

And the same request against a build of the fixes in issues/5237-masked-labels-bug:

ygjwk9bzul

Telling commented Feb 11, 2016

I've tested the additions in the issues/5237-masked-labels-bug-branch, and I can confirm that it's indeed working.

Here's a request against the released version of mapserver 7:

ixem6og4aa

And the same request against a build of the fixes in issues/5237-masked-labels-bug:

ygjwk9bzul

@tbonfort tbonfort merged commit 4196ac3 into mapserver:branch-6-4 Feb 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 11, 2016

Member

applied to branch-6-4 in 4196ac3. This was happening on polygons that where close to the image border when the label-point was computed to be outside of the image extent.

Member

tbonfort commented Feb 11, 2016

applied to branch-6-4 in 4196ac3. This was happening on polygons that where close to the image border when the label-point was computed to be outside of the image extent.

@tbonfort

This comment has been minimized.

Show comment
Hide comment
@tbonfort

tbonfort Feb 11, 2016

Member

also applied by merging to branch-7-0 in 6c13c20 and master in 27fb2d1

Member

tbonfort commented Feb 11, 2016

also applied by merging to branch-7-0 in 6c13c20 and master in 27fb2d1

@tbonfort tbonfort deleted the tbonfort:issues/5237-masked-labels-bug branch Feb 11, 2016

@AsgerPetersen

This comment has been minimized.

Show comment
Hide comment
@AsgerPetersen

AsgerPetersen Feb 12, 2016

Thank you @tbonfort. Highly appreciated!

AsgerPetersen commented Feb 12, 2016

Thank you @tbonfort. Highly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment