New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added C-style multi-line comment support to the lexer. #5362

Merged
merged 4 commits into from Jan 19, 2017

Conversation

Projects
None yet
2 participants
@sdlime
Member

sdlime commented Dec 22, 2016

Initial crack at supporting C-style comments. Both single line (e.g. /* foo /) and multi-line comments work. Only casualty is that a regex of the form /.../ can't be used since those would be recognized as the start of a comment. See ticket #4097.

@sdlime sdlime added this to the 7.2 Release milestone Dec 22, 2016

@jmckenna jmckenna assigned jmckenna and unassigned jmckenna Jan 3, 2017

@jmckenna jmckenna self-requested a review Jan 3, 2017

@jmckenna

This comment has been minimized.

Member

jmckenna commented Jan 3, 2017

This can be merged.

@sdlime

This comment has been minimized.

Member

sdlime commented Jan 19, 2017

Jeff, I added support for C-style single line comments too. So we have Perl-style and C-style. Give it a shot... --Steve

@jmckenna

This comment has been minimized.

Member

jmckenna commented Jan 19, 2017

Steve it works great!

@jmckenna jmckenna merged commit 84b0957 into mapserver:master Jan 19, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment