Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 82: Support for Enhanced Layer Metadata Management #5412

Merged
merged 1 commit into from Apr 2, 2017

Conversation

@tomkralidis tomkralidis changed the title [WIP] RFC 82 layer metadata [WIP] RFC 82: Support for Enhanced Layer Metadata Management Mar 26, 2017
@tomkralidis tomkralidis reopened this Mar 30, 2017
@tomkralidis tomkralidis changed the title [WIP] RFC 82: Support for Enhanced Layer Metadata Management RFC 82: Support for Enhanced Layer Metadata Management Mar 30, 2017
@tomkralidis

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2017

FYI this PR is ready for review. Notes:

  • implements layer level metadata. Service level metadata not implemented as part of first pass
  • Travis errors are either unrelated or I'm not able to reproduce them locally
  • there are no backward compatibility issues, however the implementation results in WMS/WFS/WCS Capabilities always providing MetadataURL type elements
@tbonfort

This comment has been minimized.

Copy link
Member

commented Mar 30, 2017

TRavis errors are due to a & appearing in generated capabilities, needs fixing

temporal = msStringSplit(value, ',', &n);
}
}
if (!value) /* SOS */

This comment has been minimized.

Copy link
@tbonfort

tbonfort Mar 30, 2017

Member

wrong bracketing or indentation

@tomkralidis tomkralidis force-pushed the tomkralidis:rfc82-layer-metadata branch from c7a1df6 to c8190e5 Mar 30, 2017
@tomkralidis

This comment has been minimized.

Copy link
Member Author

commented Mar 30, 2017

@tbonfort thanks fixed. Travis working now. Commits squashed.

@tomkralidis tomkralidis added this to the 7.2 Release milestone Apr 2, 2017
@tomkralidis tomkralidis merged commit 1b5cc9c into mapserver:master Apr 2, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomkralidis tomkralidis deleted the tomkralidis:rfc82-layer-metadata branch Apr 2, 2017
@tomkralidis

This comment has been minimized.

Copy link
Member Author

commented Apr 2, 2017

Will update docs this week.

@tomkralidis

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2017

@jmckenna given this is new functionality targeted for 7.2, should docs PR be written against master?

@tomkralidis tomkralidis referenced this pull request Apr 4, 2017
@jmckenna

This comment has been minimized.

Copy link
Member

commented Apr 4, 2017

@tomkralidis yes agreed, sorry for the confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.