Add PHP7.x support #5461
Closed
Add PHP7.x support #5461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
So this gives us PHP7 support 2 ways - via php_mapscript and Swig? --Steve |
|
Thank you very much! Will it land in mapserver 7.0 soon? |
|
I don't know quite yet. Assuming it works - I'm not a PHP user and so not in a position to test - I don't know why not. This probably needs to be taken to the mapserver-dev list for discussion. Might be good if you brought it up? There is also SWIG-based PHP 7.0 effort... --Steve |
Mapserver crashes in msQueryByFilter() if an error occurs (e.g. filteritem name is not a column name of the shape). We have to restore lp->filteritem and lp->filter. Why was this commented out?
Fixing error "undefined symbol: mapscript_create_legend" in PHP7
|
CMake says "-- Found PHP5-Version 7.2.5 (using /usr/bin/php-config)". Text should be adapted ;-) |
|
PHP-NG support added with #5675 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some macros and made some changes to the structs in php_mapcript.h for PHP7. So the code is now compatible with PHP5.x and PHP7.x.